Differential D5468

Let flask manage json response by itself
ClosedPublic
Actions

Authored by vsellier on Apr 8 2021, 7:24 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T3165: Generate historical data from the new counters series

Commits

rDCNT9958f4035e49: Let flask manage json response by itself

Summary

Flask versions between stable (1.0.2) and pip(1.1.2) have different
behaviors. The oldest version does not automatically handle a dict
as return value.

Related to T3165

Diff Detail

Repository

rDCNT Archive counters

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vsellier created this revision.Apr 8 2021, 7:24 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 8 2021, 7:24 PM

Build is green

Patch application report for D5468 (id=19541)

Rebasing onto dd8ad46f5f...

Current branch diff-target is up to date.

Changes applied before test

commit 9958f4035e494fab15b974828842738acc62b111
Author: Vincent SELLIER <vincent.sellier@softwareheritage.org>
Date:   Thu Apr 8 19:15:49 2021 +0200

    Let flask manage json response by itself
    
    Flask versions between stable (1.0.2) and pip(1.1.2) have different
    behaviors. The oldest version does not automatically handle a dict
    as return value.
    
    Related to T3165

See https://jenkins.softwareheritage.org/job/DCNT/job/tests-on-diff/36/ for more details.

Harbormaster completed remote builds in B20578: Diff 19541.Apr 8 2021, 7:25 PM

vsellier requested review of this revision.Apr 8 2021, 7:25 PM

ardumont accepted this revision.Apr 8 2021, 7:26 PM

This revision is now accepted and ready to land.Apr 8 2021, 7:26 PM

Closed by commit rDCNT9958f4035e49: Let flask manage json response by itself (authored by vsellier). · Explain WhyApr 8 2021, 7:27 PM

This revision was automatically updated to reflect the committed changes.

vsellier added a commit: rDCNT9958f4035e49: Let flask manage json response by itself.