Page MenuHomeSoftware Heritage
Differential D5454

Add pre-commit hooks, their configuration and apply fixes
ClosedPublic
Actions

Authored by anlambert on Apr 8 2021, 2:44 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Commits
rDENV0c9ef8450fd2: Fix some typos detected with codespell
rDENV7de296d04474: Apply some pre-commit fixes to all repository files
rDENVc8dc23a00a48: Add pre-commit hooks and their configuration
Summary

For consistency with other swh source code repositories.

Diff Detail

Repository
rDENV Development environment
Branch
blackify-docker-tests
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 20533
Build 31871: arc lint + arc unit

Event Timeline

anlambert created this revision.Apr 8 2021, 2:44 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptApr 8 2021, 2:44 PM
anlambert requested review of this revision.Apr 8 2021, 2:44 PM
Harbormaster completed remote builds in B20533: Diff 19491.Apr 8 2021, 2:44 PM
anlambert added a child revision: D5455: docker/tests: Fix symlink handling in test_vault_directory.Apr 8 2021, 2:49 PM
vlorentz accepted this revision.Apr 8 2021, 2:54 PM
vlorentz added a subscriber: vlorentz.

the blessed verb is "blacken", not "blackify" https://github.com/psf/black ;)

This revision is now accepted and ready to land.Apr 8 2021, 2:54 PM
vlorentz requested changes to this revision.Apr 8 2021, 2:54 PM

could you add some pre-commit config to run black?

This revision now requires changes to proceed.Apr 8 2021, 2:54 PM
anlambert added a comment.Apr 8 2021, 2:55 PM
In D5454#138366, @vlorentz wrote:

could you add some pre-commit config to run black?

Sure, will update.

anlambert updated this revision to Diff 19502.Apr 8 2021, 3:51 PM

Update:

  • Add pre-commit hooks and their configuration
  • Apply black and isort to all Python source files in the repository
  • Fix some typos detected with code spell
Harbormaster completed remote builds in B20543: Diff 19502.Apr 8 2021, 3:51 PM
vlorentz accepted this revision.Apr 8 2021, 4:15 PM

nice :)

just update the diff title before merging

This revision is now accepted and ready to land.Apr 8 2021, 4:15 PM
anlambert retitled this revision from docker/tests: Blackify python source files to Add pre-commit hooks, their configuration and apply fixes.Apr 8 2021, 4:24 PM
anlambert edited the summary of this revision. (Show Details)
Closed by commit rDENVc8dc23a00a48: Add pre-commit hooks and their configuration (authored by anlambert). · Explain WhyApr 8 2021, 4:28 PM
This revision was automatically updated to reflect the committed changes.
anlambert added a commit: rDENVc8dc23a00a48: Add pre-commit hooks and their configuration.
anlambert added a commit: rDENV7de296d04474: Apply some pre-commit fixes to all repository files.
anlambert added a commit: rDENV0c9ef8450fd2: Fix some typos detected with codespell.

Revision Contents
Changeset List

PathSize
docker/
tests/
120 lines
117 lines
41 lines
40 lines

Diff 19491

View Options

docker/tests/conftest.py

Loading...
View Options

docker/tests/test_deposit.py

Loading...
View Options

docker/tests/test_git_loader.py

Loading...
View Options

docker/tests/test_vault.py

Loading...
About · Developer information · Legal