Differential D5444

Use an intermediate temporary file to generate the historical data
ClosedPublic
Actions

Authored by vsellier on Apr 7 2021, 4:52 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T3165: Generate historical data from the new counters series

Commits

rDCNT4d940936d8f2: Use an intermediate temporary file to generate the historical data
rDCNTf2fba43f087e: Use an intermediate temporary file to generate the historical data

Summary

It will avoid the erase the file in case of problem and ensure the
webapp can't download it while it's not completely writtent on disk

Related to T3165

Diff Detail

Repository

rDCNT Archive counters

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vsellier created this revision.Apr 7 2021, 4:52 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 7 2021, 4:52 PM

Build is green

Patch application report for D5444 (id=19466)

Rebasing onto 42157fd048...

Current branch diff-target is up to date.

Changes applied before test

commit f2fba43f087e169d12b0edccd0e35451ce47a027
Author: Vincent SELLIER <vincent.sellier@softwareheritage.org>
Date:   Wed Apr 7 15:26:01 2021 +0200

    Use an intermediate temporary file to generate the historical data
    
    It will avoid the erase the file in case of problem and ensure the
    webapp can't download it while it's not completely writtent on disk
    
    Related to T3165

See https://jenkins.softwareheritage.org/job/DCNT/job/tests-on-diff/34/ for more details.

Harbormaster completed remote builds in B20510: Diff 19466.Apr 7 2021, 4:53 PM

vsellier requested review of this revision.Apr 7 2021, 4:53 PM