Differential D5418

Fix Pack File too big error formatting
ClosedPublic
Actions

Authored by aastha1999 on Apr 5 2021, 9:22 AM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T3132: loader-git: Bad formatting of the "Pack file too big" error message

Commits

rDLDG8327ec6d523a: Add contributors file
rDLDGeaa0590c1894: Fix Pack File too big error formatting

Summary

Fix T3132

Diff Detail

Repository

rDLDG Git loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

aastha1999 created this revision.Apr 5 2021, 9:22 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 5 2021, 9:22 AM

Build is green

Patch application report for D5418 (id=19372)

Rebasing onto 1eb1c57389...

Current branch diff-target is up to date.

Changes applied before test

commit eaa0590c189493a86a1a7db797c8e48fc020461f
Author: aastha1999 <asthana.aastha1999@gmail.com>
Date:   Sun Apr 4 20:32:26 2021 +0000

    Fix Pack File too big error formatting

See https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/93/ for more details.

Harbormaster completed remote builds in B20429: Diff 19372.Apr 5 2021, 9:24 AM

aastha1999 requested review of this revision.Apr 5 2021, 9:24 AM

lgtm

Please, add yourself to the top-level CONTRIBUTORS file [1]

[1] if there is none, you can add one. Format is:

firstname lastname (nickname)

The nickname is optional so leave blank after the lastname.

This revision is now accepted and ready to land.Apr 6 2021, 9:33 AM

Add contributors file

Build is green

Patch application report for D5418 (id=19472)

Rebasing onto 1eb1c57389...

Current branch diff-target is up to date.

Changes applied before test

commit 8327ec6d523a77c1c50c87d86ac0b5856a1e7929
Author: aastha1999 <asthana.aastha1999@gmail.com>
Date:   Wed Apr 7 16:39:30 2021 +0000

    Add contributors file

commit eaa0590c189493a86a1a7db797c8e48fc020461f
Author: aastha1999 <asthana.aastha1999@gmail.com>
Date:   Sun Apr 4 20:32:26 2021 +0000

    Fix Pack File too big error formatting

See https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/94/ for more details.

Harbormaster completed remote builds in B20515: Diff 19472.Apr 7 2021, 6:44 PM

@aastha1999 don't forget to send your patch https://docs.softwareheritage.org/devel/contributing/phabricator.html#updating-your-branch-to-reflect-requested-changes

Closed by commit rDLDGeaa0590c1894: Fix Pack File too big error formatting (authored by aastha1999). · Explain WhyApr 10 2021, 1:02 PM

This revision was automatically updated to reflect the committed changes.

aastha1999 added a commit: rDLDGeaa0590c1894: Fix Pack File too big error formatting.

aastha1999 added a commit: rDLDG8327ec6d523a: Add contributors file.