Details
- Reviewers
ardumont - Group Reviewers
Reviewers - Maniphest Tasks
- T3153: Create "howto" / tutorials in the developer documentation
- Commits
- rDLDBASEcdaad2122951: package-loader-tutorial: Add 'Testing your loader' section
Diff Detail
- Repository
- rDLDBASE Generic VCS/Package Loader
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Build is green
Patch application report for D5410 (id=19356)
Could not rebase; Attempt merge onto ec5a76c6d9...
Updating ec5a76c..5d29d17 Fast-forward docs/README.rst | 1 + docs/index.rst | 2 + docs/package-loader-tutorial.rst | 364 +++++++++++++++++++++++++++++++++++++++ 3 files changed, 367 insertions(+) create mode 100644 docs/package-loader-tutorial.rst
Changes applied before test
commit 5d29d17d3e9639ff99f76c1b02b16dc697284233
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Fri Apr 2 13:58:29 2021 +0200
package-loader-tutorial: Add 'Testing your loader' section
commit 0eeb712bb1620df4075b8f7057f86abe4fd149aa
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Thu Apr 1 14:14:05 2021 +0200
Start writing a package loader tutorial.
This contains the basic, from creating files to getting a working
(but untested and inefficient) loader.See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/460/ for more details.
Build is green
Patch application report for D5410 (id=19361)
Could not rebase; Attempt merge onto ec5a76c6d9...
Updating ec5a76c..e83a0b9 Fast-forward docs/README.rst | 1 + docs/index.rst | 2 + docs/package-loader-tutorial.rst | 364 +++++++++++++++++++++++++++++++++++++++ 3 files changed, 367 insertions(+) create mode 100644 docs/package-loader-tutorial.rst
Changes applied before test
commit e83a0b973a06cd8d33eb1bfb77b9a44ed772349a
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Fri Apr 2 13:58:29 2021 +0200
package-loader-tutorial: Add 'Testing your loader' section
commit 0eeb712bb1620df4075b8f7057f86abe4fd149aa
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Thu Apr 1 14:14:05 2021 +0200
Start writing a package loader tutorial.
This contains the basic, from creating files to getting a working
(but untested and inefficient) loader.See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/461/ for more details.
Build is green
Patch application report for D5410 (id=19362)
Could not rebase; Attempt merge onto ec5a76c6d9...
Updating ec5a76c..cdaad21 Fast-forward docs/README.rst | 1 + docs/index.rst | 2 + docs/package-loader-tutorial.rst | 364 +++++++++++++++++++++++++++++++++++++++ 3 files changed, 367 insertions(+) create mode 100644 docs/package-loader-tutorial.rst
Changes applied before test
commit cdaad2122951b47ab20ee03e4c97eb67b5716eb1
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Fri Apr 2 13:58:29 2021 +0200
package-loader-tutorial: Add 'Testing your loader' section
commit 0eeb712bb1620df4075b8f7057f86abe4fd149aa
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Thu Apr 1 14:14:05 2021 +0200
Start writing a package loader tutorial.
This contains the basic, from creating files to getting a working
(but untested and inefficient) loader.See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/462/ for more details.
Awesome, one suggestion inline.
| docs/package-loader-tutorial.rst | ||
|---|---|---|
| 340 | you made a strong case with olasd about checking the requests_mock_datadir has been called, so i suggest to add this part as well here. | |
| docs/package-loader-tutorial.rst | ||
|---|---|---|
| 340 | can you remind me our arguments were? ^^ | |
| docs/package-loader-tutorial.rst | ||
|---|---|---|
| 340 | on irc, i did not remember the details. something like https://forge.softwareheritage.org/source/swh-loader-core/browse/master/swh/loader/package/nixguix/tests/test_nixguix.py$0-129 some better version surely exists. | |