Paths

Table of Contentst

Differential D5404

common/identifiers: Remove branch name processing in SWHID resolver
ClosedPublic
Actions

Authored by anlambert on Apr 1 2021, 5:36 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T3195: Some SWHIDs provided by the WebApp produce 404 when resolved

Commits

rDWAPPS103b85d1c6c2: common/identifiers: Remove branch name processing in SWHID resolver

Summary

Previously the SWHID resolver was trying to associate a branch name to
a revision by checking tip revisions in snapshot branches list.

That operation is not really needed, can be costly to execute and can
lead to regressions in SWHID resolving so remove it.

Related to T3195

Diff Detail

Repository

rDWAPPS Web applications

Branch

swhid-resolve-no-branch-name

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 20401
Build 31661: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 31660: arc lint + arc unit

Event Timeline

anlambert created this revision.Apr 1 2021, 5:36 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 1 2021, 5:36 PM

vlorentz published this revision for review.Apr 1 2021, 5:41 PM

vlorentz accepted this revision.

This revision is now accepted and ready to land.Apr 1 2021, 5:41 PM

you can remove lookup_snapshot_branch_name_from_tip_revision, it's dead code now

Build is green

Patch application report for D5404 (id=19337)

Rebasing onto a42327ff4f...

Current branch diff-target is up to date.

Changes applied before test

commit a938f9e48d90f8efadeb45ad8ec70f34766b9002
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Apr 1 17:31:25 2021 +0200

    common/identifiers: Remove branch name processing in SWHID resolver
    
    Previously the SWHID resolver was trying to associate a branch name to
    a revision by checking tip revisions in snapshot branches list.
    
    That operation is not really needed, can be costly to execute and can
    lead to regressions in SWHID resolving so remove it.
    
    Related to T3195

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/645/ for more details.

Harbormaster completed remote builds in B20399: Diff 19337.Apr 1 2021, 5:43 PM

Remove dead code.

Rebase

Build is green

Patch application report for D5404 (id=19339)

Rebasing onto 07f06cba53...

First, rewinding head to replay your work on top of it...
Applying: common/identifiers: Remove branch name processing in SWHID resolver

Changes applied before test

commit e2a9a13c7ab399b8065413b270fea98e149ef150
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Apr 1 17:31:25 2021 +0200

    common/identifiers: Remove branch name processing in SWHID resolver
    
    Previously the SWHID resolver was trying to associate a branch name to
    a revision by checking tip revisions in snapshot branches list.
    
    That operation is not really needed, can be costly to execute and can
    lead to regressions in SWHID resolving so remove it.
    
    Related to T3195

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/646/ for more details.

Harbormaster completed remote builds in B20401: Diff 19339.Apr 1 2021, 5:55 PM

Build is green

Patch application report for D5404 (id=19340)

Rebasing onto 07f06cba53...

Current branch diff-target is up to date.

Changes applied before test

commit 103b85d1c6c2933202903e94eb24abc098987172
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Apr 1 17:31:25 2021 +0200

    common/identifiers: Remove branch name processing in SWHID resolver
    
    Previously the SWHID resolver was trying to associate a branch name to
    a revision by checking tip revisions in snapshot branches list.
    
    That operation is not really needed, can be costly to execute and can
    lead to regressions in SWHID resolving so remove it.
    
    Related to T3195

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/647/ for more details.

Harbormaster completed remote builds in B20402: Diff 19340.Apr 1 2021, 6:02 PM

Closed by commit rDWAPPS103b85d1c6c2: common/identifiers: Remove branch name processing in SWHID resolver (authored by anlambert). · Explain WhyApr 1 2021, 6:21 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS103b85d1c6c2: common/identifiers: Remove branch name processing in SWHID resolver.