Differential D5376

common/origin_save: Add typing information
ClosedPublic
Actions

Authored by anlambert on Mar 29 2021, 4:37 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDWAPPSce7dceb4d98f: common/origin_save: Add typing information

Summary

Currently working on this file to fix a save code now reporting issue
so add missing type annotations.

Diff Detail

Repository

rDWAPPS Web applications

Branch

origin-save-typing

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 20324
Build 31553: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 31552: arc lint + arc unit

Event Timeline

anlambert created this revision.Mar 29 2021, 4:37 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 29 2021, 4:37 PM

Build is green

Patch application report for D5376 (id=19254)

Rebasing onto fda3589aa8...

Current branch diff-target is up to date.

Changes applied before test

commit ce7dceb4d98fe2a1390128444df0bfa6b243a86c
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Mon Mar 29 16:35:24 2021 +0200

    common/origin_save: Add typing information

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/638/ for more details.

Harbormaster completed remote builds in B20324: Diff 19254.Mar 29 2021, 4:44 PM

anlambert requested review of this revision.Mar 29 2021, 4:44 PM

lgtm

This revision is now accepted and ready to land.Mar 29 2021, 4:56 PM

Closed by commit rDWAPPSce7dceb4d98f: common/origin_save: Add typing information (authored by anlambert). · Explain WhyMar 29 2021, 6:12 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPSce7dceb4d98f: common/origin_save: Add typing information.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

swh/

web/

common/

origin_save.py

52 lines

93%

Diff 19254

View Options

swh/web/common/origin_save.py

common/origin_save: Add typing informationClosedPublicActions