docs/sys-info: Update information and rework sentence phrasing
ClosedPublic
Actions

Authored by ardumont on Mar 25 2021, 6:28 PM.

Details

Reviewers

vsellier

Group Reviewers

Reviewers

Commits

rDDEPf075f2d72dec: docs/sys-info: Update information and rework sentence phrasing

Summary

This notably add links to icinga checks and explicit some too implicit actions.

Test Plan

make -C docs happy

Diff Detail

Repository

rDDEP Push deposit

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Mar 25 2021, 6:28 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 25 2021, 6:28 PM

Build is green

Patch application report for D5342 (id=19150)

Rebasing onto 59adffc64d...

Current branch diff-target is up to date.

Changes applied before test

commit 4caa1f9d6e47480c20113e36c504b818f7a426c7
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Mar 25 18:26:30 2021 +0100

    docs/sys-info: Rework phrasing a bit

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/600/ for more details.

Harbormaster completed remote builds in B20232: Diff 19150.Mar 25 2021, 6:31 PM

ardumont requested review of this revision.Mar 25 2021, 6:31 PM

vsellier requested changes to this revision.Mar 25 2021, 6:51 PM

vsellier added a subscriber: vsellier.

vsellier added inline comments.

docs/sys-info.rst
41
87
97

This revision now requires changes to proceed.Mar 25 2021, 6:51 PM

vsellier added inline comments.Mar 25 2021, 6:52 PM

docs/sys-info.rst
87	oops forget this one ;)

Adapt according to review
add links to icinga checks
Rework commit message

ardumont retitled this revision from docs/sys-info: Rework phrasing a bit to docs/sys-info: Update information and rework sentence phrasing.Mar 25 2021, 7:06 PM

ardumont edited the summary of this revision. (Show Details)

ardumont marked 4 inline comments as done.

Build is green

Patch application report for D5342 (id=19155)

Rebasing onto 59adffc64d...

Current branch diff-target is up to date.

Changes applied before test

commit f075f2d72dec98851ea3b94657caa7d7c4390040
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Mar 25 18:26:30 2021 +0100

    docs/sys-info: Update information and rework sentence phrasing
    
    This notably add links to icinga checks and explicit some too implicit actions.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/603/ for more details.

Harbormaster completed remote builds in B20237: Diff 19155.Mar 25 2021, 7:08 PM

lgtm

This revision is now accepted and ready to land.Mar 26 2021, 10:17 AM

Closed by commit rDDEPf075f2d72dec: docs/sys-info: Update information and rework sentence phrasing (authored by ardumont). · Explain WhyMar 26 2021, 10:30 AM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDDEPf075f2d72dec: docs/sys-info: Update information and rework sentence phrasing.