py-template: Make the default README link to docs/README.rst
ClosedPublic
Actions

Authored by ardumont on Mar 25 2021, 1:59 PM.

Details

Reviewers

vlorentz
moranegg
anlambert

Group Reviewers

Reviewers

Commits

rDTPLc65dda5809ce: py-template: Make the default README link to docs/README.rst

Summary

This will avoid potential new modules to migrate as well to this scheme.

Diff Detail

Repository

rDTPL Python module template

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Mar 25 2021, 1:59 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 25 2021, 1:59 PM

Harbormaster failed remote builds in B20214: Diff 19129!

Fix missing change in setup.py (the stanza that reads the readme needed to be updated)

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 25 2021, 2:38 PM

Harbormaster failed remote builds in B20217: Diff 19132!

Can this build go green?

anlambert accepted this revision.Mar 25 2021, 5:42 PM

This revision is now accepted and ready to land.Mar 25 2021, 5:42 PM

This revision was landed with ongoing or failed builds.Mar 25 2021, 5:54 PM

Closed by commit rDTPLc65dda5809ce: py-template: Make the default README link to docs/README.rst (authored by ardumont). · Explain Why

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDTPLc65dda5809ce: py-template: Make the default README link to docs/README.rst.

Can this build go green?

I concluded that not.

$ git checkout origin/master (<- without that diff)
$  swh  tony  yavin4  ~  work  …  swh  swh-environment  swh-py-template   ⚓ 4a9e193  %  tox
GLOB sdist-make: /home/tony/work/inria/repo/swh/swh-environment/swh-py-template/setup.py
ERROR: invocation failed (exit code 1), logfile: /home/tony/work/inria/repo/swh/swh-environment/swh-py-template/.tox/log/GLOB-0.log
================================================================================================================== log start ==================================================================================================================
error in swh.<module-name> setup command: ("EntryPoint must be in 'name=module:attrs [extras]' format", '<cli-name>=swh.<module>.cli')

=================================================================================================================== log end ===================================================================================================================
ERROR: FAIL could not package project - v = InvocationError('/home/tony/.virtualenvs/swh/bin/python3 setup.py sdist --formats=zip --dist-dir /home/tony/work/inria/repo/swh/swh-environment/swh-py-template/.tox/dist', 1)

iso bug so i pushed nonetheless.

ardumont mentioned this in D5354: Deduplicate docs/index.rst using a link to README.rst.Mar 26 2021, 2:00 PM