Differential D5321

Allow prometheus to retrieve the counter values
ClosedPublic
Actions

Authored by vsellier on Mar 24 2021, 5:32 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T3164: Expose counters in prometheus format

Commits

rDCNT7dbe186b010a: Allow prometheus to retrieve the counter values

Summary

Add a method to get the list of counters on the backend
Add an endpoint on the rpc to expose the counters values in the prometheus format
The way redis was instantiated by the fixture needed to be changed to always start a new test with an empty redis

Related to T3164

Diff Detail

Repository

rDCNT Archive counters

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 20177
Build 31323: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 31322: arc lint + arc unit

Event Timeline

vsellier created this revision.Mar 24 2021, 5:32 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 24 2021, 5:32 PM

Build is green

Patch application report for D5321 (id=19085)

Rebasing onto d88278619d...

Current branch diff-target is up to date.

Changes applied before test

commit 7dbe186b010ac07473b57c975e16f0d4c50bf4b2
Author: Vincent SELLIER <vincent.sellier@softwareheritage.org>
Date:   Wed Mar 24 17:13:13 2021 +0100

    Allow prometheus to retrieve the counter values
    
    - Add a method to get the list of counters on the backend
    - Add an endpoint on the rpc to expose the counters values in the
      prometheus format
    - The way redis was instantiated by the fixture needed to be
      changed to always start a new test with an empty redis
    
    Related to T3164

See https://jenkins.softwareheritage.org/job/DCNT/job/tests-on-diff/14/ for more details.

Harbormaster completed remote builds in B20177: Diff 19085.Mar 24 2021, 5:33 PM

vsellier requested review of this revision.Mar 24 2021, 5:33 PM

ardumont accepted this revision.Mar 24 2021, 6:18 PM

This revision is now accepted and ready to land.Mar 24 2021, 6:18 PM

Closed by commit rDCNT7dbe186b010a: Allow prometheus to retrieve the counter values (authored by vsellier). · Explain WhyMar 24 2021, 6:23 PM

This revision was automatically updated to reflect the committed changes.

vsellier added a commit: rDCNT7dbe186b010a: Allow prometheus to retrieve the counter values.