Page MenuHomeSoftware Heritage
Differential D531

tests: make the CeleryTestFixture also configure the resuls_backend if possible
ClosedPublic
Actions

Authored by douardda on Oct 15 2018, 11:01 AM.

Details

Reviewers
ardumont
Commits
rDSCH8df816a8ee42: tests: properly implement Celery broker and result configuration for tests…
Summary

needed by vlorentz in D518

Diff Detail

Repository
rDSCH Scheduling utilities
Branch
celery-backend
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1650
Build 1994: arc lint + arc unit

Event Timeline

douardda created this revision.Oct 15 2018, 11:01 AM
Harbormaster completed remote builds in B1650: Diff 1646.Oct 15 2018, 11:01 AM
vlorentz requested changes to this revision.Oct 15 2018, 3:02 PM

As discussed on IRC, current_app.conf does not seem to have any impact. A solution is to do as I did in D518 (particularly swh/indexer/tests/__init__.py)

This revision now requires changes to proceed.Oct 15 2018, 3:02 PM
douardda updated this revision to Diff 1670.Oct 17 2018, 12:20 PM

updated the implementation to use memory:// based celery urls

Harbormaster completed remote builds in B1669: Diff 1670.Oct 17 2018, 12:20 PM
douardda mentioned this in D519: tests: add a CeleryTestFixture that allows to specify a celery broker URL.Oct 17 2018, 12:20 PM
douardda updated this revision to Diff 1671.Oct 17 2018, 12:56 PM

simplify a bit more by only setting env vars if needed

Harbormaster completed remote builds in B1670: Diff 1671.Oct 17 2018, 12:56 PM
ardumont accepted this revision.Oct 17 2018, 2:51 PM
ardumont added a subscriber: ardumont.

Sounds simpler indeed.

README.md
33 ↗(On Diff #1671)

setting ... environment variables up.
or
configuring...

douardda updated this revision to Diff 1678.Oct 17 2018, 4:06 PM

fix typos in the readme file

Harbormaster completed remote builds in B1673: Diff 1678.Oct 17 2018, 4:06 PM
ardumont accepted this revision.Oct 17 2018, 4:12 PM
ardumont removed a reviewer: vlorentz.
This revision is now accepted and ready to land.Oct 17 2018, 4:12 PM
ardumont added a comment.Oct 17 2018, 4:13 PM

(Resigned valentin since we said one reviewer was ok.
Somehow i could not do that without doing the above.)

douardda updated this revision to Diff 1687.Oct 18 2018, 9:30 AM

rebase

Harbormaster completed remote builds in B1677: Diff 1687.Oct 18 2018, 9:30 AM
Closed by commit rDSCH8df816a8ee42: tests: properly implement Celery broker and result configuration for tests… (authored by douardda). · Explain WhyOct 18 2018, 9:31 AM
This revision was automatically updated to reflect the committed changes.
douardda mentioned this in D518: Add tests using Celery..Oct 19 2018, 10:50 AM

Revision Contents
Changeset List

PathSize
swh/
scheduler/
tests/
8 lines

Diff 1646

View Options

swh/scheduler/tests/celery_testing.py

Loading...
About · Developer information · Legal