Page MenuHomeSoftware Heritage
Differential D5312

auth.keycloak: Define keycloak_error_message helper function
ClosedPublic
Actions

Authored by ardumont on Mar 23 2021, 5:02 PM.

Details

Reviewers
anlambert
Group Reviewers
Reviewers
Maniphest Tasks
T3166: Deploy deposit v0.13 in staging
Commits
rDAUTHb3d3ff60392b: auth.keycloak: Define keycloak_error_message helper function
Summary

To ease transforming KeycloakError into an exception message.

Related to T3166

Test Plan

tox

Diff Detail

Event Timeline

ardumont created this revision.Mar 23 2021, 5:02 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptMar 23 2021, 5:02 PM
swh-public-ci added a comment.Mar 23 2021, 5:03 PM

Build is green

Patch application report for D5312 (id=19054)

Rebasing onto d7ecd21e2f...

First, rewinding head to replay your work on top of it...
Applying: auth.keycloak: Define keycloak_error_message helper function
Changes applied before test
commit 50f1f0209b39f76e6732feb73bc9b89b20b0116c
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Mar 23 17:01:38 2021 +0100

    auth.keycloak: Define keycloak_error_message helper function
    
    To ease transforming KeycloakError into an exception message.
    
    Related to T3166

See https://jenkins.softwareheritage.org/job/DAUTH/job/tests-on-diff/40/ for more details.

Harbormaster completed remote builds in B20133: Diff 19054.Mar 23 2021, 5:03 PM
ardumont requested review of this revision.Mar 23 2021, 5:03 PM
ardumont mentioned this in D5311: deposit.auth: Fix authentication failure corner case.Mar 23 2021, 5:03 PM
ardumont updated this revision to Diff 19055.Mar 23 2021, 5:10 PM

Simplify test

swh-public-ci added a comment.Mar 23 2021, 5:11 PM

Build is green

Patch application report for D5312 (id=19055)

Rebasing onto d7ecd21e2f...

First, rewinding head to replay your work on top of it...
Applying: auth.keycloak: Define keycloak_error_message helper function
Changes applied before test
commit 7655e9f6a66ad5c90615e48b67d9d757758f3ac7
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Mar 23 17:01:38 2021 +0100

    auth.keycloak: Define keycloak_error_message helper function
    
    To ease transforming KeycloakError into an exception message.
    
    Related to T3166

See https://jenkins.softwareheritage.org/job/DAUTH/job/tests-on-diff/41/ for more details.

Harbormaster completed remote builds in B20134: Diff 19055.Mar 23 2021, 5:11 PM
ardumont updated this revision to Diff 19056.Mar 23 2021, 5:11 PM

Drop spurious pass instruction

swh-public-ci added a comment.Mar 23 2021, 5:12 PM

Build is green

Patch application report for D5312 (id=19056)

Rebasing onto d7ecd21e2f...

First, rewinding head to replay your work on top of it...
Applying: auth.keycloak: Define keycloak_error_message helper function
Changes applied before test
commit 38593eb0951f3ef7750f4ad74b18b880fd990258
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Mar 23 17:01:38 2021 +0100

    auth.keycloak: Define keycloak_error_message helper function
    
    To ease transforming KeycloakError into an exception message.
    
    Related to T3166

See https://jenkins.softwareheritage.org/job/DAUTH/job/tests-on-diff/42/ for more details.

Harbormaster completed remote builds in B20135: Diff 19056.Mar 23 2021, 5:12 PM
ardumont updated this revision to Diff 19057.Mar 23 2021, 5:15 PM

Rework docstring sentence phrasing.

swh-public-ci added a comment.Mar 23 2021, 5:15 PM

Build is green

Patch application report for D5312 (id=19057)

Rebasing onto d7ecd21e2f...

First, rewinding head to replay your work on top of it...
Applying: auth.keycloak: Define keycloak_error_message helper function
Changes applied before test
commit ac24c4fc0d2a9f3f20d23b47b3bdb2ba2ba0547a
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Mar 23 17:01:38 2021 +0100

    auth.keycloak: Define keycloak_error_message helper function
    
    To ease transforming KeycloakError into an exception message.
    
    Related to T3166

See https://jenkins.softwareheritage.org/job/DAUTH/job/tests-on-diff/43/ for more details.

Harbormaster completed remote builds in B20136: Diff 19057.Mar 23 2021, 5:15 PM
anlambert accepted this revision.Mar 23 2021, 5:27 PM
anlambert added a subscriber: anlambert.

Great, thanks !

This revision is now accepted and ready to land.Mar 23 2021, 5:27 PM
ardumont updated this revision to Diff 19058.Mar 23 2021, 5:33 PM

Rebase

swh-public-ci added a comment.Mar 23 2021, 5:34 PM

Build is green

Patch application report for D5312 (id=19058)

Rebasing onto d7ecd21e2f...

Current branch diff-target is up to date.
Changes applied before test
commit b3d3ff60392bf664b10e39bb9d4f45f17e3e144c
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Mar 23 17:01:38 2021 +0100

    auth.keycloak: Define keycloak_error_message helper function
    
    To ease transforming KeycloakError into an exception message.
    
    Related to T3166

See https://jenkins.softwareheritage.org/job/DAUTH/job/tests-on-diff/44/ for more details.

Harbormaster completed remote builds in B20137: Diff 19058.Mar 23 2021, 5:34 PM
Closed by commit rDAUTHb3d3ff60392b: auth.keycloak: Define keycloak_error_message helper function (authored by ardumont). · Explain WhyMar 23 2021, 5:35 PM
This revision was automatically updated to reflect the committed changes.
ardumont added a commit: rDAUTHb3d3ff60392b: auth.keycloak: Define keycloak_error_message helper function.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
swh/
auth/
13 lines90%
Loading...
tests/
29 lines100%
Loading...

Diff 19054

View Options

swh/auth/keycloak.py

Loading...
View Options

swh/auth/tests/test_keycloak.py

Loading...
About · Developer information · Legal