Page MenuHomeSoftware Heritage

auth: Use OIDCUser model directly instead of inheriting from it
ClosedPublic

Authored by anlambert on Mar 23 2021, 3:41 PM.

Details

Summary

Use of auto_created flag has been moved to swh-auth which prevents
the model to be saved to database and makes the app_label flag use
now pointless.

Related to T3150

Depends on D5309

Diff Detail

Repository
rDWAPPS Web applications
Branch
remove-oidc-user-class
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 20117
Build 31240: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 31239: arc lint + arc unit

Event Timeline

lgtm

you probably need a bump in the requirements for swh.auth
if not already done in earlier diff (i don't recall seeing one).

Build is green

Patch application report for D5310 (id=19041)

Rebasing onto 9b2507a81b...

Current branch diff-target is up to date.
Changes applied before test
commit 75c71adc4b4b16fbbb80f68a2fc8d03010172542
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Tue Mar 23 15:36:46 2021 +0100

    auth: Use OIDCUser model directly instead of inheriting from it
    
    Use of auto_created flag has been moved to swh-auth which prevents
    the model to be saved to database and makes the app_label flag use
    now pointless.
    
    Related to T3150

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/633/ for more details.

This revision is now accepted and ready to land.Mar 23 2021, 3:48 PM

Bump swh-auth requirement and ensure django components

Build has FAILED

Patch application report for D5310 (id=19044)

Rebasing onto 9b2507a81b...

Current branch diff-target is up to date.
Changes applied before test
commit fda3589aa85f5a1b26513f67cae6d849a3c8620a
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Tue Mar 23 15:36:46 2021 +0100

    auth: Use OIDCUser model directly instead of inheriting from it
    
    Use of auto_created flag has been moved to swh-auth which prevents
    the model to be saved to database and makes the app_label flag use
    now pointless.
    
    Related to T3150

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/634/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/634/console

Build is green

Patch application report for D5310 (id=19044)

Rebasing onto 9b2507a81b...

Current branch diff-target is up to date.
Changes applied before test
commit fda3589aa85f5a1b26513f67cae6d849a3c8620a
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Tue Mar 23 15:36:46 2021 +0100

    auth: Use OIDCUser model directly instead of inheriting from it
    
    Use of auto_created flag has been moved to swh-auth which prevents
    the model to be saved to database and makes the app_label flag use
    now pointless.
    
    Related to T3150

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/635/ for more details.