Page MenuHomeSoftware Heritage
Differential D5164

Fix snapshot page title
AbandonedPublic
Actions

Authored by KShivendu on Mar 1 2021, 5:37 AM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Maniphest Tasks
T2801: Wrong <title> on snapshot pages
Summary

Fixes T2801

Diff Detail

Repository
rDWAPPS Web applications
Branch
fix-snapshot-title
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 19547
Build 30329: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 30328: arc lint + arc unit

Event Timeline

KShivendu created this revision.Mar 1 2021, 5:37 AM
Herald added a reviewer: Reviewers. · View Herald TranscriptMar 1 2021, 5:37 AM
swh-public-ci added a comment.Mar 1 2021, 5:44 AM

Build is green

Patch application report for D5164 (id=18470)

Rebasing onto d91cbf3780...

Current branch diff-target is up to date.
Changes applied before test
commit 51c7de9c4bd0613cbd18daf96e76b47a04790e60
Author: KShivendu <shivendu@iitbhilai.ac.in>
Date:   Mon Mar 1 10:05:53 2021 +0530

    Fix snapshot page title

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/589/ for more details.

Harbormaster completed remote builds in B19547: Diff 18470.Mar 1 2021, 5:44 AM
KShivendu requested review of this revision.Mar 1 2021, 5:44 AM
vlorentz requested changes to this revision.Mar 1 2021, 2:02 PM
vlorentz added a subscriber: vlorentz.

Hi, thanks again.

Could you add a test?

swh/web/browse/snapshot_context.py
840

no space before a colon

843

same here

844

Shouldn't the branch remain before the path?

This revision now requires changes to proceed.Mar 1 2021, 2:02 PM
KShivendu marked 3 inline comments as done.Mar 2 2021, 5:36 PM

Hi @vlorentz. The test should be from the frontend or backend?

anlambert added a subscriber: anlambert.Mar 2 2021, 6:00 PM

@KShivendu , I am not sure that change is needed, see T2801#59654.

Otherwise, tests should be written for the backend to check expected title string is well present in the produced HTML.

I do not think we added tests to check HTML title pages so far so that diff could evolve to add those.

KShivendu abandoned this revision.Sep 6 2022, 8:34 AM

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
swh/
web/
browse/
11 lines79%
Loading...

Diff 18470

View Options

swh/web/browse/snapshot_context.py

Loading...
About · Developer information · Legal