Differential D5153

deposit.urls: Retro-compatibility fix about import and type conflict
ClosedPublic
Actions

Authored by ardumont on Feb 26 2021, 11:56 AM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T3072: deposit: Unstuck buster debian build

Commits

rDDEP8b66a7c45be2: deposit.urls: Retro-compatibility fix about import and type conflict

Summary

We now type this module with django version which allows us to.

This fixes the debian buster build [1]

[1] https://jenkins.softwareheritage.org/job/debian/job/packages/job/DDEP/job/gbp-buildpackage/94/consoleFull

Closes T3072

Diff Detail

Repository

rDDEP Push deposit

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 19512
Build 30271: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 30270: arc lint + arc unit

Event Timeline

ardumont created this revision.Feb 26 2021, 11:56 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 26 2021, 11:56 AM

Build is green

Patch application report for D5153 (id=18432)

Rebasing onto ce5c76c732...

Current branch diff-target is up to date.

Changes applied before test

commit 02b0a5b2b574d5ac6c56b1f151983968ce7c3a82
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Feb 26 11:36:23 2021 +0100

    deposit.urls: Retro-compatibility fix about import and type conflict
    
    We now type this module with django version which allows us to.
    
    This fixes the debian buster build [1]
    
    [1] https://jenkins.softwareheritage.org/job/debian/job/packages/job/DDEP/job/gbp-buildpackage/94/consoleFull
    
    Closes T3072

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/542/ for more details.

Harbormaster completed remote builds in B19511: Diff 18432.Feb 26 2021, 11:59 AM

ardumont requested review of this revision.Feb 26 2021, 11:59 AM

vlorentz accepted this revision.Feb 26 2021, 12:01 PM

vlorentz added a subscriber: vlorentz.

vlorentz added inline comments.

swh/deposit/urls.py
20

This revision is now accepted and ready to land.Feb 26 2021, 12:01 PM

rework comment according to suggestion

ardumont marked an inline comment as done.Feb 26 2021, 12:06 PM

Build is green

Patch application report for D5153 (id=18433)

Rebasing onto ce5c76c732...

Current branch diff-target is up to date.

Changes applied before test

commit 8b66a7c45be20b40163b8343eb0979ed81806a0b
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Feb 26 11:36:23 2021 +0100

    deposit.urls: Retro-compatibility fix about import and type conflict
    
    We now type this module with django version which allows us to.
    
    This fixes the debian buster build [1]
    
    [1] https://jenkins.softwareheritage.org/job/debian/job/packages/job/DDEP/job/gbp-buildpackage/94/consoleFull
    
    Closes T3072

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/543/ for more details.

Harbormaster completed remote builds in B19512: Diff 18433.Feb 26 2021, 12:07 PM

Closed by commit rDDEP8b66a7c45be2: deposit.urls: Retro-compatibility fix about import and type conflict (authored by ardumont). · Explain WhyFeb 26 2021, 12:07 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDDEP8b66a7c45be2: deposit.urls: Retro-compatibility fix about import and type conflict.