Differential D5143

Aggregate deposit archives into a temporary tarball instead of a zip
ClosedPublic
Actions

Authored by ardumont on Feb 25 2021, 2:33 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T3070: Fix longstanding deposit status verified which is usually a symptom of loading failure

Commits

rDDEPb7893b782854: Aggregate deposit archives into a temporary tarball instead of a zip

Summary

The internal detail of zip format revealed a limitation when it comes to date anterior
to 1980. The tar format seems to overcome that limitation so we switch to internally use
such format.

Related to T3070

Fixes D5142

Test Plan

tox

Diff Detail

Repository

rDDEP Push deposit

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 19468
Build 30205: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 30204: arc lint + arc unit

Event Timeline

ardumont created this revision.Feb 25 2021, 2:33 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 25 2021, 2:33 PM

ardumont edited the summary of this revision. (Show Details)Feb 25 2021, 2:34 PM

Build is green

Patch application report for D5143 (id=18389)

Rebasing onto 6275caba93...

Current branch diff-target is up to date.

Changes applied before test

commit 2a43d2b082544552774336425a3d36cfa35987a9
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Feb 25 12:01:58 2021 +0100

    deposit_read: Aggregate deposit archives into a temporary tarball
    
    Instead of a zip. The internal detail of zip format revealed a limitation when it comes
    to date anterior to 1980. The tar format seems to overcome that limitation so we switch
    to internally use such format.
    
    Related to T3070

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/539/ for more details.

Harbormaster completed remote builds in B19467: Diff 18389.Feb 25 2021, 2:35 PM

ardumont requested review of this revision.Feb 25 2021, 2:35 PM

Please add "Instead of a zip" in the first line of the commit msg, it completely changes the understanding of what the commit does

This revision is now accepted and ready to land.Feb 25 2021, 2:43 PM

ardumont retitled this revision from deposit_read: Aggregate deposit archives into a temporary tarball to Aggregate deposit archives into a temporary tarball instead of a zip.Feb 25 2021, 2:57 PM

ardumont edited the summary of this revision. (Show Details)

Rework commit message

Build is green

Patch application report for D5143 (id=18390)

Rebasing onto 6275caba93...

Current branch diff-target is up to date.

Changes applied before test

commit b7893b782854655bb52ad4d225d348a520c78f74
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Feb 25 12:01:58 2021 +0100

    Aggregate deposit archives into a temporary tarball instead of a zip
    
    The internal detail of zip format revealed a limitation when it comes to date anterior
    to 1980. The tar format seems to overcome that limitation so we switch to internally use
    such format.
    
    Related to T3070

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/540/ for more details.

Harbormaster completed remote builds in B19468: Diff 18390.Feb 25 2021, 3:02 PM

Closed by commit rDDEPb7893b782854: Aggregate deposit archives into a temporary tarball instead of a zip (authored by ardumont). · Explain WhyFeb 25 2021, 3:52 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDDEPb7893b782854: Aggregate deposit archives into a temporary tarball instead of a zip.

ardumont mentioned this in D5142: deposit.tests: Reproduce staging error.Feb 25 2021, 4:07 PM