Page MenuHomeSoftware Heritage
Differential D5130

Create a clearly-defined-full database on db1.staging
ClosedPublic
Actions

Authored by olasd on Feb 23 2021, 4:15 PM.

Details

Reviewers
ardumont
Commits
rSPSITE127322a80177: Create a clearly-defined-full database on db1.staging
rSPSITEa3052e46e432: Give olasd .pgpass and .pg_service.conf on clearly-defined
rSPSITEa198d66632e5: postgresql server: allow overriding the db password
Summary

with two small refactorings to share the database owner

Test Plan

octocatalog-diff on db1 and clearly-defined

Diff Detail

Repository
rSPSITE puppet-swh-site
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Feb 23 2021, 4:15 PM
Harbormaster completed remote builds in B19429: Diff 18349.Feb 23 2021, 4:15 PM
olasd requested review of this revision.Feb 23 2021, 4:15 PM
ardumont added inline comments.Feb 23 2021, 4:33 PM
data/hostname/clearly-defined.internal.staging.swh.network.yaml
26

mmm, there is something fishy with the passwd and password keys.
It should be either password or passwd but i don't recall which...

(issue already present in here in the non green part of the diff)

ardumont added inline comments.Feb 23 2021, 4:35 PM
data/hostname/clearly-defined.internal.staging.swh.network.yaml
26

The template pgpass uses the passwd version [1]

[1] https://forge.softwareheritage.org/source/puppet-swh-site/browse/production/site-modules/profile/templates/postgres/pgpass.conf.erb$5

This revision was not accepted when it landed; it landed in state Needs Review.Feb 23 2021, 4:47 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rSPSITEa3052e46e432: Give olasd .pgpass and .pg_service.conf on clearly-defined (authored by olasd). · Explain Why
This revision was automatically updated to reflect the committed changes.
olasd added a commit: rSPSITEa3052e46e432: Give olasd .pgpass and .pg_service.conf on clearly-defined.
olasd added a commit: rSPSITEa198d66632e5: postgresql server: allow overriding the db password.
olasd added a commit: rSPSITE127322a80177: Create a clearly-defined-full database on db1.staging.

Revision Contents
Changeset List

Diff 18351

View Options

data/hostname/clearly-defined.internal.staging.swh.network.yaml

Loading...
About · Developer information · Legal