Differential D5122

browse/search: Enable to filter origins by visit type
ClosedPublic
Actions

Authored by anlambert on Feb 19 2021, 5:32 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T2869: web search: allow to filter by origin type

Commits

rDWAPPSd91cbf378089: browse/search: Enable to filter origins by visit type

Summary

Add a new dropdown in the right part of the search form in order to
filter searched origins by visit type (git, hg, pypi, svn, ...).

Related to T2869

Diff Detail

Repository

rDWAPPS Web applications

Branch

origin-visit-type-search

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 19398
Build 30085: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 30084: arc lint + arc unit

Event Timeline

anlambert created this revision.Feb 19 2021, 5:32 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 19 2021, 5:32 PM

Build is green

Patch application report for D5122 (id=18313)

Rebasing onto 7768774bf7...

Current branch diff-target is up to date.

Changes applied before test

commit 93ca5ca104379b5a28cc5103868d64983616e9cf
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Feb 10 16:50:43 2021 +0100

    browse/search: Enable to filter origins by visit type
    
    Add a new dropdown in the right part of the search form in order to
    filter searched origins by visit type (git, hg, pypi, svn, ...).
    
    Related to T2869

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/583/ for more details.

Harbormaster completed remote builds in B19398: Diff 18313.Feb 19 2021, 5:40 PM

anlambert requested review of this revision.Feb 19 2021, 5:40 PM

What about "visit type" instead of "origin type" in the UI? It's next to the checkbox "only show origins visited at least once" so it should not be too confusing

In D5122#129468, @vlorentz wrote:

What about "visit type" instead of "origin type" in the UI? It's next to the checkbox "only show origins visited at least once" so it should not be too confusing

You're right, I will make the change.

s/origin type/visit type/

anlambert edited the summary of this revision. (Show Details)Feb 19 2021, 6:14 PM

Build is green

Patch application report for D5122 (id=18318)

Rebasing onto 7768774bf7...

Current branch diff-target is up to date.

Changes applied before test

commit d91cbf378089310c774421f41d1df197b303c31f
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Feb 10 16:50:43 2021 +0100

    browse/search: Enable to filter origins by visit type
    
    Add a new dropdown in the right part of the search form in order to
    filter searched origins by visit type (git, hg, pypi, svn, ...).
    
    Related to T2869

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/584/ for more details.

Harbormaster completed remote builds in B19403: Diff 18318.Feb 19 2021, 6:20 PM

vlorentz accepted this revision.Feb 19 2021, 6:50 PM

This revision is now accepted and ready to land.Feb 19 2021, 6:50 PM

Closed by commit rDWAPPSd91cbf378089: browse/search: Enable to filter origins by visit type (authored by anlambert). · Explain WhyFeb 19 2021, 7:19 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPSd91cbf378089: browse/search: Enable to filter origins by visit type.