Differential D5111

assets/origin-search: Rework latest origin visit processing code
ClosedPublic
Actions

Authored by anlambert on Feb 18 2021, 5:03 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDWAPPS7768774bf797: assets/origin-search: Rework latest origin visit processing code

Summary

Handle 404 error code when querying /origin/visit/latest/ API endpoint.

Move error handling in a catch block.

Add missing cypress test.

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Feb 18 2021, 5:03 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 18 2021, 5:03 PM

Build has FAILED

Patch application report for D5111 (id=18255)

Rebasing onto f34eca7521...

Current branch diff-target is up to date.

Changes applied before test

commit a46a430803cd0b527efb5324cd3b72ba819d6b9e
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Feb 11 14:31:08 2021 +0100

    assets/origin-search: Rework latest origin visit processing code
    
    Handle 404 error code when querying /origin/visit/latest/ API endpoint.
    
    Move error handling in a catch block.
    
    Add missing cypress test.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/581/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/581/console

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 18 2021, 5:10 PM

Harbormaster failed remote builds in B19351: Diff 18255!

Fix cypress test

Build is green

Patch application report for D5111 (id=18256)

Rebasing onto f34eca7521...

Current branch diff-target is up to date.

Changes applied before test

commit 7768774bf7979f8f8078dab8d1e0d4a640b9ab27
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Feb 11 14:31:08 2021 +0100

    assets/origin-search: Rework latest origin visit processing code
    
    Handle 404 error code when querying /origin/visit/latest/ API endpoint.
    
    Move error handling in a catch block.
    
    Add missing cypress test.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/582/ for more details.

Harbormaster completed remote builds in B19352: Diff 18256.Feb 18 2021, 5:29 PM

anlambert requested review of this revision.Feb 18 2021, 5:29 PM

vlorentz accepted this revision.Feb 19 2021, 9:43 AM

This revision is now accepted and ready to land.Feb 19 2021, 9:43 AM

Closed by commit rDWAPPS7768774bf797: assets/origin-search: Rework latest origin visit processing code (authored by anlambert). · Explain WhyFeb 19 2021, 11:39 AM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS7768774bf797: assets/origin-search: Rework latest origin visit processing code.