Page MenuHomeSoftware Heritage

elasticsearch: Disable date_detection in origin mapping
ClosedPublic

Authored by vlorentz on Feb 18 2021, 12:07 PM.

Details

Summary

So that if the first document with a given field has a date-like value
in that field, Elasticsearch does not enforce that all documents and
queries on that field use a data.

Also, in the same test checking this, add a similar check for numeric
values, in case 'numeric_detection' ever gets turned on by default.

Diff Detail

Repository
rDSEA Archive search
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 19325
Build 29962: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 29961: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D5106 (id=18228)

Rebasing onto 0fa1f6deb5...

First, rewinding head to replay your work on top of it...
Applying: elasticsearch: Disable date_detection in origin mapping
Changes applied before test
commit 4f128873f669001e037f940a8310f0473d4f231a
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Feb 18 12:07:03 2021 +0100

    elasticsearch: Disable date_detection in origin mapping
    
    So that if the first document with a given field has a date-like value
    in that field, Elasticsearch does not enforce that all documents and
    queries on that field use a data.
    
    Also, in the same test checking this, add a similar check for numeric
    values, in case 'numeric_detection' ever gets turned on by default.

See https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/85/ for more details.

This revision is now accepted and ready to land.Feb 18 2021, 12:12 PM
This revision was landed with ongoing or failed builds.Feb 18 2021, 12:14 PM
This revision was automatically updated to reflect the committed changes.

Build is green

Patch application report for D5106 (id=18229)

Rebasing onto 589ef4d8c4...

First, rewinding head to replay your work on top of it...
Fast-forwarded diff-target to base-revision-86-D5106.
Changes applied before test

See https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/86/ for more details.