common/origin_save: Handle new "not_found" origin visit status
ClosedPublic
Actions

Authored by anlambert on Feb 17 2021, 4:45 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T3030: Improve loaders to deal with new visit status events

Commits

rDWAPPSa38de155ccdd: common/origin_save: Handle new "not_found" origin visit status

Summary

Save requests with an associated visit status set to "not_found" must be
reported as failed ones.

Related to T3030

Diff Detail

Repository

rDWAPPS Web applications

Branch

origin-save-handle-not-found

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 19301
Build 29931: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 29930: arc lint + arc unit

Event Timeline

anlambert created this revision.Feb 17 2021, 4:45 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 17 2021, 4:45 PM

Build is green

Patch application report for D5096 (id=18202)

Rebasing onto 2fbbbb95ef...

Current branch diff-target is up to date.

Changes applied before test

commit a38de155ccdd9a488b5bfd027189c4b302ddf93f
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Feb 17 16:43:58 2021 +0100

    common/origin_save: Handle new "not_found" origin visit status
    
    Save requests with an associated visit status set to "not_found" must be
    reported as failed ones.
    
    Related to T3030

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/576/ for more details.

Harbormaster completed remote builds in B19301: Diff 18202.Feb 17 2021, 4:52 PM

anlambert requested review of this revision.Feb 17 2021, 4:52 PM

ardumont accepted this revision.Feb 17 2021, 4:54 PM

This revision is now accepted and ready to land.Feb 17 2021, 4:54 PM

Closed by commit rDWAPPSa38de155ccdd: common/origin_save: Handle new "not_found" origin visit status (authored by anlambert). · Explain WhyFeb 17 2021, 4:56 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPSa38de155ccdd: common/origin_save: Handle new "not_found" origin visit status.