Differential D5093

tests: Fix loader-git instantiation
ClosedPublic
Actions

Authored by ardumont on Feb 17 2021, 1:49 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Maniphest Tasks

T1410: Kill implicit configuration: new configuration scheme

Commits

rDWAPPS2e0ccea86a61: tests: Fix loader-git instantiation

Summary

Related to T1410

Test Plan

tox
(failing until swh.loader.git > 0.7 is released)

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Feb 17 2021, 1:49 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 17 2021, 1:49 PM

ardumont mentioned this in D5077: Rework loader instantiation logic according to loader core api.Feb 17 2021, 1:49 PM

Build has FAILED

Patch application report for D5093 (id=18187)

Rebasing onto 113957105c...

Current branch diff-target is up to date.

Changes applied before test

commit 2e0ccea86a6130809d593c7cce70c3e17fe37436
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Feb 17 13:49:22 2021 +0100

    tests: Fix loader-git instantiation
    
    Related to T1410

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/572/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/572/console

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 17 2021, 1:50 PM

Harbormaster failed remote builds in B19288: Diff 18187!

ardumont mentioned this in D5094: api_route: Ensure never_cache is honored for all response status codes.Feb 17 2021, 2:25 PM

Build is green

Patch application report for D5093 (id=18187)

Rebasing onto 113957105c...

Current branch diff-target is up to date.

Changes applied before test

commit 2e0ccea86a6130809d593c7cce70c3e17fe37436
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Feb 17 13:49:22 2021 +0100

    tests: Fix loader-git instantiation
    
    Related to T1410

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/574/ for more details.

Harbormaster completed remote builds in B19288: Diff 18187.Feb 17 2021, 3:18 PM

ardumont requested review of this revision.Feb 17 2021, 3:18 PM

anlambert accepted this revision.Feb 17 2021, 3:19 PM

This revision is now accepted and ready to land.Feb 17 2021, 3:19 PM

Closed by commit rDWAPPS2e0ccea86a61: tests: Fix loader-git instantiation (authored by ardumont). · Explain WhyFeb 17 2021, 3:19 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDWAPPS2e0ccea86a61: tests: Fix loader-git instantiation.