Page MenuHomeSoftware Heritage
Differential D5089

docker: Cleanup docker-compose.yml file
ClosedPublic
Actions

Authored by anlambert on Feb 16 2021, 7:02 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDENVdcd7a5df118b: docker: Remove unused services in docker-compose.yml
rDENV61eb09d83cad: docker: Harmonize docker-compose.yml formatting
Summary

Harmonize YAML formatting and remove some unused services:

  • flower as it has always been deactivated
  • kafka-manager as it is not mandatory to run the swh stack.

Diff Detail

Repository
rDENV Development environment
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Feb 16 2021, 7:02 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 16 2021, 7:02 PM
anlambert requested review of this revision.Feb 16 2021, 7:02 PM
Harbormaster completed remote builds in B19269: Diff 18165.Feb 16 2021, 7:02 PM
anlambert updated this revision to Diff 18166.Feb 16 2021, 7:04 PM

Remove file commited by mistake

Harbormaster completed remote builds in B19270: Diff 18166.Feb 16 2021, 7:04 PM
ardumont accepted this revision.Feb 16 2021, 7:13 PM
ardumont added a subscriber: ardumont.

looks fine to me.

I'd maybe move the kafka-manager in another related journal related docker-compose file (if we have some).

This revision is now accepted and ready to land.Feb 16 2021, 7:13 PM
anlambert added a comment.Feb 16 2021, 7:21 PM

I'd maybe move the kafka-manager in another related journal related docker-compose file (if we have some).

I tested it back yersteday, there is no automatic cluster detection and I did not manage to configure it manually so the removal.
I guess we should find a more reliable tool if we need kafka monitoring in docker.

Closed by commit rDENV61eb09d83cad: docker: Harmonize docker-compose.yml formatting (authored by anlambert). · Explain WhyFeb 16 2021, 7:24 PM
This revision was automatically updated to reflect the committed changes.
anlambert added a commit: rDENV61eb09d83cad: docker: Harmonize docker-compose.yml formatting.
anlambert added a commit: rDENVdcd7a5df118b: docker: Remove unused services in docker-compose.yml.
ardumont mentioned this in T3471: production: Deploy swh.scheduler v0.17.Aug 13 2021, 3:48 PM

Revision Contents
Changeset List

PathSize
docker/
41 lines

Diff 18169

View Options

docker/docker-compose.yml

Loading...
About · Developer information · Legal