Page MenuHomeSoftware Heritage
Differential D5083

Declare ArchiveInterface and ProvenanceInterface as Protocol
ClosedPublic
Actions

Authored by douardda on Feb 16 2021, 3:44 PM.

Details

Reviewers
aeviso
Commits
rDPROV3b96ecadfa8b: Declare ArchiveInterface and ProvenanceInterface as Protocol
Summary

and add missing type annotations here and there.

Depends on D5073

Diff Detail

Repository
rDPROV Provenance database
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda requested review of this revision.Feb 16 2021, 3:44 PM
douardda created this revision.
Harbormaster completed remote builds in B19254: Diff 18150.Feb 16 2021, 3:44 PM
douardda updated this revision to Diff 18158.Feb 16 2021, 5:34 PM

rebase

Harbormaster completed remote builds in B19262: Diff 18158.Feb 16 2021, 5:34 PM
douardda added a child revision: D5098: Add basic tests for the provenanceDB and archive abstraction classes.Feb 17 2021, 5:36 PM
aeviso accepted this revision.Feb 18 2021, 2:05 PM
aeviso added a subscriber: aeviso.

I guess this is the correct way to define interfaces in Python. I don't get way ArchiveStorage doesn't inherit from ArchiveInterface though.

This revision is now accepted and ready to land.Feb 18 2021, 2:05 PM
douardda updated this revision to Diff 18263.Feb 18 2021, 5:50 PM

rebased

Harbormaster completed remote builds in B19357: Diff 18263.Feb 18 2021, 5:50 PM
Closed by commit rDPROV3b96ecadfa8b: Declare ArchiveInterface and ProvenanceInterface as Protocol (authored by douardda). · Explain WhyFeb 19 2021, 10:01 AM
This revision was automatically updated to reflect the committed changes.
douardda added a commit: rDPROV3b96ecadfa8b: Declare ArchiveInterface and ProvenanceInterface as Protocol.

Revision Contents
Changeset List

PathSize
swh/
provenance/
26 lines
20 lines
postgresql/
9 lines
90 lines
storage/
8 lines

Diff 18280

View Options

swh/provenance/__init__.py

Loading...
View Options

swh/provenance/archive.py

Loading...
View Options

swh/provenance/postgresql/provenancedb_base.py

Loading...
View Options

swh/provenance/provenance.py

Loading...
View Options

swh/provenance/storage/archive.py

Loading...
About · Developer information · Legal