Differential D5033

succeeded)
ClosedPublic
Actions

Authored by anlambert on Feb 5 2021, 4:15 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDWAPPS90a3931454ac: admin/origin-save: Fix typo in save task status (s/succeed/succeeded)

Summary

That was missed in rDWAPPSc53756359a43340d08d96a90c05a5b49dec52dbb and
prevented the origin browse link to be displayed in "Save code now"
admin interface.

Diff Detail

Repository

rDWAPPS Web applications

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 19059
Build 29541: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 29540: arc lint + arc unit

Event Timeline

anlambert created this revision.Feb 5 2021, 4:15 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 5 2021, 4:15 PM

Build is green

Patch application report for D5033 (id=17940)

Rebasing onto 558990abd8...

Current branch diff-target is up to date.

Changes applied before test

commit 90a3931454ac7b118b23f6d9db9880e04f1fb3e7
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Feb 5 16:13:19 2021 +0100

    admin/origin-save: Fix typo in save task status (s/succeed/succeeded)
    
    That was missed in rDWAPPSc53756359a43340d08d96a90c05a5b49dec52dbb and
    prevented the origin browse link to be displayed in "Save code now"
    admin interface.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/567/ for more details.

Harbormaster completed remote builds in B19059: Diff 17940.Feb 5 2021, 4:21 PM

anlambert requested review of this revision.Feb 5 2021, 4:21 PM

ardumont accepted this revision.Feb 5 2021, 4:22 PM

This revision is now accepted and ready to land.Feb 5 2021, 4:22 PM

Closed by commit rDWAPPS90a3931454ac: admin/origin-save: Fix typo in save task status (s/succeed/succeeded) (authored by anlambert). · Explain WhyFeb 5 2021, 5:19 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS90a3931454ac: admin/origin-save: Fix typo in save task status (s/succeed/succeeded).