Differential D4987

cgit: remove the repository urls's trailing /
ClosedPublic
Actions

Authored by vsellier on Feb 1 2021, 5:34 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T3013: Deploy remaining next-gen listers on staging

Commits

rDLS8e4dd178f1df: cgit: remove the repository urls's trailing /

Summary

Ensure the behavior is the same when a base url is provided or not

Related to T3013#57810

Diff Detail

Repository

rDLS Listers

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 18927
Build 29329: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 29328: arc lint + arc unit

Event Timeline

vsellier created this revision.Feb 1 2021, 5:34 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 1 2021, 5:34 PM

Build is green

Patch application report for D4987 (id=17786)

Rebasing onto 003cf5491f...

Current branch diff-target is up to date.

Changes applied before test

commit 8e4dd178f1df983d3fba2eac1c279cfe6081b9db
Author: Vincent SELLIER <vincent.sellier@softwareheritage.org>
Date:   Mon Feb 1 17:31:08 2021 +0100

    cgit: remove the repository urls's trailing /
    
    Ensure the behavior is the same when a base url is provided or not
    
    Related to T3013#57810

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/233/ for more details.

Harbormaster completed remote builds in B18927: Diff 17786.Feb 1 2021, 5:37 PM

vsellier requested review of this revision.Feb 1 2021, 5:37 PM

This also ensures we stay consistent with the prior cgit listers and the existing origins we have currently in the archive.

ardumont accepted this revision.Feb 1 2021, 5:48 PM

This revision is now accepted and ready to land.Feb 1 2021, 5:48 PM

ardumont mentioned this in T3013: Deploy remaining next-gen listers on staging.Feb 1 2021, 5:48 PM

Closed by commit rDLS8e4dd178f1df: cgit: remove the repository urls's trailing / (authored by vsellier). · Explain WhyFeb 1 2021, 5:50 PM

This revision was automatically updated to reflect the committed changes.

vsellier added a commit: rDLS8e4dd178f1df: cgit: remove the repository urls's trailing /.