Differential D4893

Make the max_date() helper function accept *dates as argument
ClosedPublic
Actions

Authored by douardda on Jan 20 2021, 12:42 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDSCHc386fdf3b9fc: Make the max_date() helper function accept *dates as argument

Summary

so it can be called with more than 2 dates.

Diff Detail

Repository

rDSCH Scheduling utilities

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Jan 20 2021, 12:42 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJan 20 2021, 12:42 PM

douardda added a child revision: D4894: Simplify journal client tests.Jan 20 2021, 12:42 PM

Build is green

Patch application report for D4893 (id=17384)

Rebasing onto b03d978241...

Current branch diff-target is up to date.

Changes applied before test

commit c386fdf3b9fc30946177e1ec0c05e0e814243f42
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Jan 20 12:24:10 2021 +0100

    Make the max_date() helper function accept *dates as argument
    
    so it can be called with more than 2 dates.

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/182/ for more details.

Harbormaster completed remote builds in B18520: Diff 17384.Jan 20 2021, 12:44 PM

douardda requested review of this revision.Jan 20 2021, 12:44 PM

ardumont accepted this revision.Jan 20 2021, 4:33 PM

This revision is now accepted and ready to land.Jan 20 2021, 4:33 PM

Closed by commit rDSCHc386fdf3b9fc: Make the max_date() helper function accept *dates as argument (authored by douardda). · Explain WhyJan 20 2021, 5:29 PM

This revision was automatically updated to reflect the committed changes.

douardda added a commit: rDSCHc386fdf3b9fc: Make the max_date() helper function accept *dates as argument.