Page MenuHomeSoftware Heritage

db: Allow new status values not_found and failed to OriginVisitStatus
ClosedPublic

Authored by ardumont on Jan 20 2021, 10:47 AM.

Diff Detail

Repository
rDSTO Storage manager
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18511
Build 28633: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 28632: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D4892 (id=17376)

Rebasing onto d04165f5b4...

Current branch diff-target is up to date.
Changes applied before test
commit 14a08fa9e97f3cc4b5d8411775eeeca8c71aabdf
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jan 20 10:38:34 2021 +0100

    db: Allow new status value 'not_found' to OriginVisitStatus
    
    Related to T2961

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1106/ for more details.

olasd added a subscriber: olasd.

(As long as this matches what ends up being done in D4891).

This reminds me that I noticed this morning that the bump to schema version 165 was forgotten in c24d35f86a06 (in db.py and 30-schema.sql).

This revision is now accepted and ready to land.Jan 20 2021, 11:28 AM

This reminds me that I noticed this morning that the bump to schema version 165 was forgotten in c24d35f86a06 (in db.py and 30-schema.sql).

Indeed.

Adapt diff according to the model update (adding the failed state as well)

ardumont retitled this revision from db: Allow new status value 'not_found' to OriginVisitStatus to db: Allow new status values not_found and failed to OriginVisitStatus.Jan 20 2021, 2:05 PM

Build has FAILED

Patch application report for D4892 (id=17389)

Rebasing onto d04165f5b4...

Current branch diff-target is up to date.
Changes applied before test
commit 9ceeab6da5b19097b7c5df4d3c2460d2f8b6bdcc
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jan 20 10:38:34 2021 +0100

    db: Allow new status values not_found, failed to OriginVisitStatus
    
    Related to T2961

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1107/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1107/console

Fix trailing comma which sql is not happy about ¯\_(ツ)_/¯

Build is green

Patch application report for D4892 (id=17398)

Rebasing onto d04165f5b4...

Current branch diff-target is up to date.
Changes applied before test
commit e433255dabff0976efa673866ccd62f80bc94f99
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jan 20 10:38:34 2021 +0100

    db: Allow new status values not_found, failed to OriginVisitStatus
    
    Related to T2961

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1108/ for more details.