Page MenuHomeSoftware Heritage
Differential D4891

model: Allow new status values not_found and failed to OriginVisitStatus
ClosedPublic
Actions

Authored by ardumont on Jan 20 2021, 10:33 AM.

Details

Reviewers
olasd
vlorentz
Group Reviewers
Reviewers
Maniphest Tasks
T2961: Add a "not_found" value in OriginVisitStatus.status
Commits
rDMOD9af451fd6248: model: Allow new status values not_found and failed to OriginVisitStatus
Summary

Related to T2961

Diff Detail

Repository
rDMOD Data model
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18509
Build 28629: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 28628: arc lint + arc unit

Event Timeline

ardumont created this revision.Jan 20 2021, 10:33 AM
Herald added a reviewer: Reviewers. · View Herald TranscriptJan 20 2021, 10:33 AM
swh-public-ci added a comment.Jan 20 2021, 10:35 AM

Build is green

Patch application report for D4891 (id=17373)

Rebasing onto 1ca92a5ce0...

Current branch diff-target is up to date.
Changes applied before test
commit b125f0760b8c27f40c325c49ee5635ab40379dda
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jan 20 10:31:38 2021 +0100

    model: Allow new status value 'not_found' to OriginVisitStatus
    
    Related to T2961

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/200/ for more details.

Harbormaster completed remote builds in B18509: Diff 17373.Jan 20 2021, 10:35 AM
ardumont requested review of this revision.Jan 20 2021, 10:35 AM
olasd accepted this revision.Jan 20 2021, 11:27 AM
olasd added a subscriber: olasd.

This makes me wonder if we shouldn't add an explicit failed status too, while we're at it, for explicit failures that couldn't generate a partial snapshot.

This revision is now accepted and ready to land.Jan 20 2021, 11:27 AM
vlorentz requested changes to this revision.Jan 20 2021, 11:28 AM
vlorentz added a subscriber: vlorentz.

missing an update to hypothesis_strategies.py

This revision now requires changes to proceed.Jan 20 2021, 11:28 AM
olasd mentioned this in D4892: db: Allow new status values not_found and failed to OriginVisitStatus.Jan 20 2021, 11:28 AM
ardumont added subscribers: vsellier, douardda.Jan 20 2021, 11:40 AM

This makes me wonder if we shouldn't add an explicit failed status too, while we're at it, for explicit failures that couldn't generate a partial snapshot.

I'd be fine with that indeed.

I think we entertain the idea with @douardda and @vsellier

missing an update to hypothesis_strategies.py

yes, thanks for the heads up.

douardda added a comment.Jan 20 2021, 12:48 PM
In D4891#122658, @ardumont wrote:

This makes me wonder if we shouldn't add an explicit failed status too, while we're at it, for explicit failures that couldn't generate a partial snapshot.

I'd be fine with that indeed.

I think we entertain the idea with @douardda and @vsellier

ye we did.

I think we should add it right now, even if we do not use it right away. It should not harm anything...

ardumont updated this revision to Diff 17388.Jan 20 2021, 2:02 PM

Address reviews

  • add failed status
  • update swh.model.hypothesis_strategies module according to changes
swh-public-ci added a comment.Jan 20 2021, 2:03 PM

Build is green

Patch application report for D4891 (id=17388)

Rebasing onto 1ca92a5ce0...

Current branch diff-target is up to date.
Changes applied before test
commit 9af451fd6248ea3159f35bcca23e6ef28c7f505a
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jan 20 10:31:38 2021 +0100

    model: Allow new status values not_found and failed to OriginVisitStatus
    
    Related to T2961

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/201/ for more details.

Harbormaster completed remote builds in B18524: Diff 17388.Jan 20 2021, 2:04 PM
vlorentz accepted this revision.Jan 20 2021, 2:04 PM

thx. don't forget to update the diff title

This revision is now accepted and ready to land.Jan 20 2021, 2:04 PM
ardumont retitled this revision from model: Allow new status value 'not_found' to OriginVisitStatus to model: Allow new status values not_found and failed to OriginVisitStatus.Jan 20 2021, 2:05 PM
Closed by commit rDMOD9af451fd6248: model: Allow new status values not_found and failed to OriginVisitStatus (authored by ardumont). · Explain WhyJan 20 2021, 3:31 PM
This revision was automatically updated to reflect the committed changes.
ardumont added a commit: rDMOD9af451fd6248: model: Allow new status values not_found and failed to OriginVisitStatus.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
swh/
model/
4 lines96%
Loading...

Diff 17373

View Options

swh/model/model.py

Loading...
About · Developer information · Legal