Page MenuHomeSoftware Heritage

model: Allow new status values not_found and failed to OriginVisitStatus
ClosedPublic

Authored by ardumont on Jan 20 2021, 10:33 AM.

Diff Detail

Repository
rDMOD Data model
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D4891 (id=17373)

Rebasing onto 1ca92a5ce0...

Current branch diff-target is up to date.
Changes applied before test
commit b125f0760b8c27f40c325c49ee5635ab40379dda
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jan 20 10:31:38 2021 +0100

    model: Allow new status value 'not_found' to OriginVisitStatus
    
    Related to T2961

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/200/ for more details.

olasd added a subscriber: olasd.

This makes me wonder if we shouldn't add an explicit failed status too, while we're at it, for explicit failures that couldn't generate a partial snapshot.

This revision is now accepted and ready to land.Jan 20 2021, 11:27 AM
vlorentz added a subscriber: vlorentz.

missing an update to hypothesis_strategies.py

This revision now requires changes to proceed.Jan 20 2021, 11:28 AM

This makes me wonder if we shouldn't add an explicit failed status too, while we're at it, for explicit failures that couldn't generate a partial snapshot.

I'd be fine with that indeed.

I think we entertain the idea with @douardda and @vsellier

missing an update to hypothesis_strategies.py

yes, thanks for the heads up.

This makes me wonder if we shouldn't add an explicit failed status too, while we're at it, for explicit failures that couldn't generate a partial snapshot.

I'd be fine with that indeed.

I think we entertain the idea with @douardda and @vsellier

ye we did.

I think we should add it right now, even if we do not use it right away. It should not harm anything...

Address reviews

  • add failed status
  • update swh.model.hypothesis_strategies module according to changes

Build is green

Patch application report for D4891 (id=17388)

Rebasing onto 1ca92a5ce0...

Current branch diff-target is up to date.
Changes applied before test
commit 9af451fd6248ea3159f35bcca23e6ef28c7f505a
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jan 20 10:31:38 2021 +0100

    model: Allow new status values not_found and failed to OriginVisitStatus
    
    Related to T2961

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/201/ for more details.

thx. don't forget to update the diff title

This revision is now accepted and ready to land.Jan 20 2021, 2:04 PM
ardumont retitled this revision from model: Allow new status value 'not_found' to OriginVisitStatus to model: Allow new status values not_found and failed to OriginVisitStatus.Jan 20 2021, 2:05 PM