Page MenuHomeSoftware Heritage

requirements: Make swh.journal and optional dependency
ClosedPublic

Authored by ardumont on Jan 19 2021, 12:07 PM.

Details

Summary

This avoids pulling journal dependencies when modules only needs the swh-scheduler
dependency.

Test Plan

tox

Diff Detail

Repository
rDSCH Scheduling utilities
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D4879 (id=17333)

Could not rebase; Attempt merge onto 58ca79622d...

Updating 58ca796..5e609d5
Fast-forward
 mypy.ini                                |   3 +
 requirements-journal.txt                |   1 +
 setup.py                                |   5 +-
 swh/scheduler/cli/journal.py            |  57 ++++++++++++++++
 swh/scheduler/tests/test_cli_journal.py | 114 ++++++++++++++++++++++++++++++++
 5 files changed, 179 insertions(+), 1 deletion(-)
 create mode 100644 requirements-journal.txt
 create mode 100644 swh/scheduler/cli/journal.py
 create mode 100644 swh/scheduler/tests/test_cli_journal.py
Changes applied before test
commit 5e609d52059204b8ac117ec3b2e58a5d52588ec9
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Jan 19 12:04:37 2021 +0100

    requirements: Make swh.journal and optional dependency
    
    This avoids pulling journal dependencies when modules only needs the swh-scheduler
    dependency.

commit 9395aa0763b79cdde7cefbfdb1f93b03d2cb8c65
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jan 18 14:46:57 2021 +0100

    scheduler.cli.journal: Add `swh scheduler journal-client` cli
    
    This adds the cli entrypoint to actually process origin_visit_status topics and write to
    the origin_visit_stats db table.
    
    Related to T2967

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/154/ for more details.

This revision is now accepted and ready to land.Jan 19 2021, 1:49 PM