Differential D4857

Add new field OriginVisitStatus.type field on test data
ClosedPublic
Actions

Authored by vsellier on Jan 13 2021, 4:21 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T2965: Adapt storage to actually write the visit_type in the origin_visit_status topic

Commits

rDJNLc451ecd54231: Add new field OriginVisitStatus.type field on test data

Summary

Related to T2965
Depends on D4848

Test Plan

tox (will failed until D4848 is released)

Diff Detail

Repository

rDJNL Journal infrastructure

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 18335
Build 28322: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 28321: arc lint + arc unit

Event Timeline

vsellier created this revision.Jan 13 2021, 4:21 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJan 13 2021, 4:21 PM

Build has FAILED

Patch application report for D4857 (id=17189)

Rebasing onto 5f7e43378c...

Current branch diff-target is up to date.

Changes applied before test

commit f3798b70160dbe866e6c91a91286b1ead8c2b946
Author: Vincent SELLIER <vincent.sellier@softwareheritage.org>
Date:   Wed Jan 13 16:15:44 2021 +0100

    Add new field OriginVisitStatus.type field on test data
    
    Related to T2965
    Depends on D4848

Link to build: https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/138/
See console output for more information: https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/138/console

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 13 2021, 4:22 PM

Harbormaster failed remote builds in B18333: Diff 17189!

update the "Related to" on the commit message

Build has FAILED

Patch application report for D4857 (id=17191)

Rebasing onto 5f7e43378c...

Current branch diff-target is up to date.

Changes applied before test

commit c451ecd5423105047d1012aafdf1ac992e5850ba
Author: Vincent SELLIER <vincent.sellier@softwareheritage.org>
Date:   Wed Jan 13 16:15:44 2021 +0100

    Add new field OriginVisitStatus.type field on test data
    
    Related to T2964

Link to build: https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/139/
See console output for more information: https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/139/console

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 13 2021, 4:49 PM

Harbormaster failed remote builds in B18335: Diff 17191!

Build is green

Patch application report for D4857 (id=17191)

Rebasing onto 5f7e43378c...

Current branch diff-target is up to date.

Changes applied before test

commit c451ecd5423105047d1012aafdf1ac992e5850ba
Author: Vincent SELLIER <vincent.sellier@softwareheritage.org>
Date:   Wed Jan 13 16:15:44 2021 +0100

    Add new field OriginVisitStatus.type field on test data
    
    Related to T2964

See https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/140/ for more details.

Harbormaster completed remote builds in B18335: Diff 17191.Jan 14 2021, 2:24 PM

vsellier requested review of this revision.Jan 14 2021, 2:24 PM

ardumont accepted this revision.Jan 14 2021, 2:25 PM

This revision is now accepted and ready to land.Jan 14 2021, 2:25 PM

Closed by commit rDJNLc451ecd54231: Add new field OriginVisitStatus.type field on test data (authored by vsellier). · Explain WhyJan 14 2021, 2:27 PM

This revision was automatically updated to reflect the committed changes.

vsellier added a commit: rDJNLc451ecd54231: Add new field OriginVisitStatus.type field on test data.