Page MenuHomeSoftware Heritage

Implement a basic endpoint for getting the next origins to visit
ClosedPublic

Authored by vlorentz on Mon, Jan 11, 3:43 PM.

Details

Summary

The basic policy implemented is a FIFO, to get things going.

Caveats:

  • "last_scheduled" column added to the main table, which may generate index churn and impact lister performance

Author: @olasd

Test Plan

basic tox tests added for the new endpoint

Diff Detail

Repository
rDSCH Scheduling utilities
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build was aborted

Patch application report for D4835 (id=17128)

Rebasing onto 619100eaf2...

Current branch diff-target is up to date.
Changes applied before test
commit b13cb1f2de2b38348680aad3a6b97fe7937e1596
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Mon Jan 11 15:29:09 2021 +0100

    Implement a basic endpoint for getting the next origins to visit
    
    The basic policy implemented is a FIFO, to get things going.

Link to build: https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/85/
See console output for more information: https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/85/console

Harbormaster returned this revision to the author for changes because remote builds failed.Mon, Jan 11, 4:13 PM
Harbormaster failed remote builds in B18272: Diff 17128!

Build was aborted

Patch application report for D4835 (id=17128)

Rebasing onto 619100eaf2...

Current branch diff-target is up to date.
Changes applied before test
commit b13cb1f2de2b38348680aad3a6b97fe7937e1596
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Mon Jan 11 15:29:09 2021 +0100

    Implement a basic endpoint for getting the next origins to visit
    
    The basic policy implemented is a FIFO, to get things going.

Link to build: https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/86/
See console output for more information: https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/86/console

Build was aborted

Patch application report for D4835 (id=17128)

Rebasing onto 619100eaf2...

Current branch diff-target is up to date.
Changes applied before test
commit b13cb1f2de2b38348680aad3a6b97fe7937e1596
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Mon Jan 11 15:29:09 2021 +0100

    Implement a basic endpoint for getting the next origins to visit
    
    The basic policy implemented is a FIFO, to get things going.

Link to build: https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/87/
See console output for more information: https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/87/console

Build has FAILED

Patch application report for D4835 (id=17128)

Rebasing onto 619100eaf2...

Current branch diff-target is up to date.
Changes applied before test
commit b13cb1f2de2b38348680aad3a6b97fe7937e1596
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Mon Jan 11 15:29:09 2021 +0100

    Implement a basic endpoint for getting the next origins to visit
    
    The basic policy implemented is a FIFO, to get things going.

Link to build: https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/88/
See console output for more information: https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/88/console

Build was aborted

Patch application report for D4835 (id=17128)

Rebasing onto 619100eaf2...

Current branch diff-target is up to date.
Changes applied before test
commit b13cb1f2de2b38348680aad3a6b97fe7937e1596
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Mon Jan 11 15:29:09 2021 +0100

    Implement a basic endpoint for getting the next origins to visit
    
    The basic policy implemented is a FIFO, to get things going.

Link to build: https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/89/
See console output for more information: https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/89/console

Build is green

Patch application report for D4835 (id=17128)

Rebasing onto 619100eaf2...

Current branch diff-target is up to date.
Changes applied before test
commit b13cb1f2de2b38348680aad3a6b97fe7937e1596
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Mon Jan 11 15:29:09 2021 +0100

    Implement a basic endpoint for getting the next origins to visit
    
    The basic policy implemented is a FIFO, to get things going.

Deleted tag 'base-revision-90-D4835' (was 619100e)

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/90/ for more details.

ardumont added a subscriber: ardumont.

lgtm

(I have yet to check for the for update skip locked thingy ;)

This revision is now accepted and ready to land.Tue, Jan 12, 12:23 PM
vlorentz edited the summary of this revision. (Show Details)

rebase

Build is green

Patch application report for D4835 (id=17147)

Rebasing onto 619100eaf2...

Current branch diff-target is up to date.
Changes applied before test
commit b13cb1f2de2b38348680aad3a6b97fe7937e1596
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Mon Jan 11 15:29:09 2021 +0100

    Implement a basic endpoint for getting the next origins to visit
    
    The basic policy implemented is a FIFO, to get things going.

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/93/ for more details.