Differential D4825

Make the CREATE_TABLES_QUERIES in cassandra/schema.py an explicit list
ClosedPublic
Actions

Authored by douardda on Jan 8 2021, 2:09 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDSTO74e6f58e2f9b: Make the CREATE_TABLES_QUERIES in cassandra/schema.py an explicit list

Summary

prevent being fooled by a missing '\n'.

Diff Detail

Repository

rDSTO Storage manager

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Jan 8 2021, 2:09 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJan 8 2021, 2:09 PM

Build has FAILED

Patch application report for D4825 (id=17084)

Rebasing onto 2b35198d30...

Current branch diff-target is up to date.

Changes applied before test

commit 44efbe3cae717d2de3acea20fa7111d0314d8835
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Jan 8 10:44:25 2021 +0100

    Make the CREATE_TABLES_QUERIES in cassandra/schema.py an explicit list
    
    prevent being fooled by a missing '\n'.

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1081/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1081/console

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 8 2021, 2:15 PM

Harbormaster failed remote builds in B18224: Diff 17084!

attempt to do a better job at reworking git history...

Build is green

Patch application report for D4825 (id=17086)

Rebasing onto 2b35198d30...

Current branch diff-target is up to date.

Changes applied before test

commit 74e6f58e2f9b3e03b911dbe95b1f53f85db8fd42
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Jan 8 10:44:25 2021 +0100

    Make the CREATE_TABLES_QUERIES in cassandra/schema.py an explicit list
    
    prevent being fooled by a missing '\n'.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1083/ for more details.

Harbormaster completed remote builds in B18226: Diff 17086.Jan 8 2021, 2:26 PM

douardda requested review of this revision.Jan 8 2021, 2:26 PM

douardda mentioned this in D4826: Allow to use the JAVA_HOME environment for cassandra tests.Jan 8 2021, 2:28 PM

douardda added a child revision: D4826: Allow to use the JAVA_HOME environment for cassandra tests.Jan 8 2021, 2:28 PM

vlorentz accepted this revision.Jan 8 2021, 2:36 PM

This revision is now accepted and ready to land.Jan 8 2021, 2:36 PM

Closed by commit rDSTO74e6f58e2f9b: Make the CREATE_TABLES_QUERIES in cassandra/schema.py an explicit list (authored by douardda). · Explain WhyJan 13 2021, 9:44 AM

This revision was automatically updated to reflect the committed changes.

douardda added a commit: rDSTO74e6f58e2f9b: Make the CREATE_TABLES_QUERIES in cassandra/schema.py an explicit list.