Differential D4805

FUSE: cache: put by-date/ entries in direntry cache
ClosedPublic
Actions

Authored by haltode on Jan 5 2021, 10:41 AM.

Details

Reviewers

seirl

Group Reviewers

Reviewers

Maniphest Tasks

T2864: FUSE: cache history/by-date/ entries even when not done populating

Commits

rDFUSE26ee05f3bd82: cache: put by-date/ entries in direntry cache

Summary

Since those entries are updated in the background, we invalidate the
cache on a regular basis.

Close T2864. This should also fix the second problem of T2830, namely
the fact that get_entries(by_date, offset) was not reliable because of
the offset supposing the entries were the same every time.

Diff Detail

Repository

rDFUSE FUSE virtual file system

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

haltode created this revision.Jan 5 2021, 10:41 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptJan 5 2021, 10:41 AM

Build is green

Patch application report for D4805 (id=17030)

Rebasing onto b59cf2a1d1...

Current branch diff-target is up to date.

Changes applied before test

commit 3c0ac58f956ade5d74fa0ce1431d4503b4c94c51
Author: Thibault Allançon <haltode@gmail.com>
Date:   Tue Jan 5 10:37:08 2021 +0100

    cache: put by-date/ entries in direntry cache
    
    Since those entries are updated in the background, we invalidate the
    cache on a regular basis.
    
    Close T2864. This should also fix the second problem of T2830, namely
    the fact that get_entries(by_date, offset) was not reliable because of
    the offset supposing the entries were the same every time.

See https://jenkins.softwareheritage.org/job/DFUSE/job/tests-on-diff/259/ for more details.

Harbormaster completed remote builds in B18168: Diff 17030.Jan 5 2021, 10:45 AM

haltode requested review of this revision.Jan 5 2021, 10:45 AM

Use number of API calls instead of %.

Build is green

Patch application report for D4805 (id=17039)

Rebasing onto b59cf2a1d1...

Current branch diff-target is up to date.

Changes applied before test

commit 26ee05f3bd82f91b0a4a23fad4c9e7ed0c6aa28a
Author: Thibault Allançon <haltode@gmail.com>
Date:   Tue Jan 5 10:37:08 2021 +0100

    cache: put by-date/ entries in direntry cache
    
    Since those entries are updated in the background, we invalidate the
    cache on a regular basis.
    
    Close T2864. This should also fix the second problem of T2830, namely
    the fact that get_entries(by_date, offset) was not reliable because of
    the offset supposing the entries were the same every time.

See https://jenkins.softwareheritage.org/job/DFUSE/job/tests-on-diff/260/ for more details.

Harbormaster completed remote builds in B18180: Diff 17039.Jan 5 2021, 5:59 PM

seirl accepted this revision.Jan 5 2021, 6:01 PM

This revision is now accepted and ready to land.Jan 5 2021, 6:01 PM

Closed by commit rDFUSE26ee05f3bd82: cache: put by-date/ entries in direntry cache (authored by haltode). · Explain WhyJan 5 2021, 6:20 PM

This revision was automatically updated to reflect the committed changes.

haltode added a commit: rDFUSE26ee05f3bd82: cache: put by-date/ entries in direntry cache.