Differential D4749

search.journal_client: Actually filter on full origin_visit_status
ClosedPublic
Actions

Authored by ardumont on Dec 15 2020, 9:15 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDSEAc3758cf6120f: search.journal_client: Actually filter on full origin_visit_status

Summary

I think something went badly in some old rebase I did because I thought that
was already the case.

Or I may conflate with the other indexer journal client... [1]

[1] https://forge.softwareheritage.org/source/swh-indexer/browse/master/swh/indexer/journal_client.py$25

Test Plan

tox

Diff Detail

Repository

rDSEA Archive search

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 17973
Build 27764: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 27763: arc lint + arc unit

Event Timeline

ardumont created this revision.Dec 15 2020, 9:15 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptDec 15 2020, 9:15 PM

Build is green

Patch application report for D4749 (id=16817)

Rebasing onto b47bea2547...

Current branch diff-target is up to date.

Changes applied before test

commit 94c38bf61d878d618caf298f89886845baa52ff2
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Dec 15 21:12:38 2020 +0100

    search.journal_client: Actually filter on full origin_visit_status

See https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/62/ for more details.

Harbormaster completed remote builds in B17973: Diff 16817.Dec 15 2020, 9:18 PM

ardumont edited the summary of this revision. (Show Details)Dec 15 2020, 9:19 PM

oops.

no test?

Here is a test:

def test_journal_client_origin_visit_status_from_journal():
    search_mock = MagicMock()

    worker_fn = functools.partial(process_journal_objects, search=search_mock,)

    worker_fn({"origin_visit_status": [{"origin": {"url": "http://foobar.baz"}, "status": "full"}]})
    search_mock.origin_update.assert_called_once_with(
        [{"url": "http://foobar.baz", "has_visits": True},]
    )

    search_mock.reset_mock()

    worker_fn({"origin_visit_status": [{"origin": {"url": "http://foobar.baz"}, "status": "partial"}]})
    search_mock.origin_update.assert_not_called()

Add missing test

vlorentz accepted this revision.Dec 17 2020, 11:33 AM

This revision is now accepted and ready to land.Dec 17 2020, 11:33 AM

Build has FAILED

Patch application report for D4749 (id=16839)

Rebasing onto b47bea2547...

Current branch diff-target is up to date.

Changes applied before test

commit 20a9d2e349b99bfb8a3d1c80f6ad1a9729b49cc9
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Dec 15 21:12:38 2020 +0100

    search.journal_client: Actually filter on full origin_visit_status

Link to build: https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/63/
See console output for more information: https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/63/console

Harbormaster failed remote builds in B17992: Diff 16839!Dec 17 2020, 11:33 AM

Fix test

Build is green

Patch application report for D4749 (id=16845)

Rebasing onto b47bea2547...

Current branch diff-target is up to date.

Changes applied before test

commit c3758cf6120fa832455e3d9955720c6be2c89537
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Dec 15 21:12:38 2020 +0100

    search.journal_client: Actually filter on full origin_visit_status

See https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/64/ for more details.

Harbormaster completed remote builds in B17998: Diff 16845.Dec 17 2020, 12:11 PM

Closed by commit rDSEAc3758cf6120f: search.journal_client: Actually filter on full origin_visit_status (authored by ardumont). · Explain WhyDec 17 2020, 12:11 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDSEAc3758cf6120f: search.journal_client: Actually filter on full origin_visit_status.