FUSE: fix directory listing bugs
ClosedPublic
Actions

Authored by haltode on Dec 8 2020, 10:39 AM.

Details

Reviewers

Group Reviewers

Maniphest Tasks

T2842: Hang while running ls on a directory containing a symlink
T2851: FUSE: directories referencing artifacts missing from the archive are reported as empty

Commits

rDFUSE8515c5171d53: fs: directory: check first for symlink before content/directory
rDFUSE80af8893dd1c: fs: directory: ignore missing artifact for submodules

Summary

Fix T2851: fs: directory: ignore missing artifact for submodules
Fix T2842: fs: directory: check first for symlink before content/directory

Diff Detail

Repository

rDFUSE FUSE virtual file system

Branch

feature/fix-directory-compute-entries

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 17803
Build 27517: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 27516: arc lint + arc unit

Event Timeline

haltode created this revision.Dec 8 2020, 10:39 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptDec 8 2020, 10:39 AM

haltode retitled this revision from FUSE: fix directory listing bugs to WIP: FUSE: fix directory listing bugs.Dec 8 2020, 10:39 AM

Build is green

Patch application report for D4682 (id=16609)

Rebasing onto 7186852c90...

Current branch diff-target is up to date.

Changes applied before test

commit 5dcad4cd8a87b34d2fc62ff87c18193b8ce3f80c
Author: Thibault Allançon <haltode@gmail.com>
Date:   Tue Dec 8 10:35:54 2020 +0100

    fs: directory: check first for symlink before content/directory
    
    Fix T2842.

commit 80af8893dd1c01bf4493571d37184c67b1cd3d3b
Author: Thibault Allançon <haltode@gmail.com>
Date:   Tue Dec 8 10:24:45 2020 +0100

    fs: directory: ignore missing artifact for submodules
    
    Fix T2851.

See https://jenkins.softwareheritage.org/job/DFUSE/job/tests-on-diff/231/ for more details.

Harbormaster completed remote builds in B17788: Diff 16609.Dec 8 2020, 10:42 AM

Add cnt/dir symlink unit tests

haltode retitled this revision from WIP: FUSE: fix directory listing bugs to FUSE: fix directory listing bugs.Dec 8 2020, 2:15 PM

haltode edited the summary of this revision. (Show Details)

Build is green

Patch application report for D4682 (id=16627)

Rebasing onto 7186852c90...

Current branch diff-target is up to date.

Changes applied before test

commit 8515c5171d53822f2ba8dc9d8637f2df886f5ac3
Author: Thibault Allançon <haltode@gmail.com>
Date:   Tue Dec 8 10:35:54 2020 +0100

    fs: directory: check first for symlink before content/directory
    
    Fix T2842.

commit 80af8893dd1c01bf4493571d37184c67b1cd3d3b
Author: Thibault Allançon <haltode@gmail.com>
Date:   Tue Dec 8 10:24:45 2020 +0100

    fs: directory: ignore missing artifact for submodules
    
    Fix T2851.

See https://jenkins.softwareheritage.org/job/DFUSE/job/tests-on-diff/232/ for more details.

Harbormaster completed remote builds in B17803: Diff 16627.Dec 8 2020, 2:19 PM

seirl accepted this revision.Dec 8 2020, 4:09 PM

This revision is now accepted and ready to land.Dec 8 2020, 4:09 PM

Closed by commit rDFUSE80af8893dd1c: fs: directory: ignore missing artifact for submodules (authored by haltode). · Explain WhyDec 8 2020, 4:44 PM

This revision was automatically updated to reflect the committed changes.

haltode added a commit: rDFUSE80af8893dd1c: fs: directory: ignore missing artifact for submodules.

haltode added a commit: rDFUSE8515c5171d53: fs: directory: check first for symlink before content/directory.