Page MenuHomeSoftware Heritage
Differential D4628

FUSE: tests: use fixed delay in test_list_history
ClosedPublic
Actions

Authored by haltode on Nov 27 2020, 5:55 PM.

Details

Reviewers
zack
Group Reviewers
Reviewers
Commits
rDFUSE91da32397917: tests: use fixed delay in test_list_history

Diff Detail

Repository
rDFUSE FUSE virtual file system
Branch
tests/fix-by-date-ci-failing
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17624
Build 27247: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 27246: arc lint + arc unit

Event Timeline

haltode created this revision.Nov 27 2020, 5:55 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptNov 27 2020, 5:55 PM
swh-public-ci added a comment.Nov 27 2020, 5:58 PM

Build is green

Patch application report for D4628 (id=16422)

Rebasing onto 1c778776d8...

Current branch diff-target is up to date.
Changes applied before test
commit d8cf389066c82d1e6e77026c1ce800d3e61e21bb
Author: Thibault Allançon <haltode@gmail.com>
Date:   Fri Nov 27 17:50:55 2020 +0100

    tests: (temporary fix) ignore history/by-date test on remote CI

See https://jenkins.softwareheritage.org/job/DFUSE/job/tests-on-diff/196/ for more details.

Harbormaster completed remote builds in B17611: Diff 16422.Nov 27 2020, 5:58 PM
zack accepted this revision.Nov 27 2020, 6:01 PM
zack added a subscriber: zack.

LGTM.

*But*.

Please first file a task about this issue and reference it from the comment in the code, for ease of tracking.

This revision is now accepted and ready to land.Nov 27 2020, 6:01 PM
swh-public-ci added a comment.Nov 27 2020, 6:15 PM

Build has FAILED

Patch application report for D4628 (id=16422)

Rebasing onto 1c778776d8...

Current branch diff-target is up to date.
Changes applied before test
commit d8cf389066c82d1e6e77026c1ce800d3e61e21bb
Author: Thibault Allançon <haltode@gmail.com>
Date:   Fri Nov 27 17:50:55 2020 +0100

    tests: (temporary fix) ignore history/by-date test on remote CI

Link to build: https://jenkins.softwareheritage.org/job/DFUSE/job/tests-on-diff/197/
See console output for more information: https://jenkins.softwareheritage.org/job/DFUSE/job/tests-on-diff/197/console

Harbormaster failed remote builds in B17611: Diff 16422!Nov 27 2020, 6:15 PM
haltode updated this revision to Diff 16430.Nov 30 2020, 4:09 PM

tests: use fixed delay in test_list_history

Closes T2829. The ".status" file presence is currently not a reliable system to
stop the delay, so use a fixed one instead to prevent random CI fails.

haltode retitled this revision from tests: (temporary fix) ignore history/by-date test on remote CI to FUSE: tests: use fixed delay in test_list_history.Nov 30 2020, 4:09 PM
swh-public-ci added a comment.Nov 30 2020, 4:12 PM

Build is green

Patch application report for D4628 (id=16430)

Rebasing onto 1c778776d8...

Current branch diff-target is up to date.
Changes applied before test
commit eede0f7beea1ffd1ec55a49c5d05873067874bb0
Author: Thibault Allançon <haltode@gmail.com>
Date:   Fri Nov 27 17:50:55 2020 +0100

    tests: use fixed delay in test_list_history
    
    Closes T2829. The ".status" file presence is currently not a reliable
    system to stop the delay, so use a fixed one instead to prevent random
    CI fails.
    
    TODO: new task about re-doing the .status implementation

See https://jenkins.softwareheritage.org/job/DFUSE/job/tests-on-diff/200/ for more details.

Harbormaster completed remote builds in B17619: Diff 16430.Nov 30 2020, 4:12 PM
haltode updated this revision to Diff 16431.Nov 30 2020, 4:19 PM

CI test

swh-public-ci added a comment.Nov 30 2020, 4:22 PM

Build is green

Patch application report for D4628 (id=16431)

Rebasing onto 1c778776d8...

Current branch diff-target is up to date.
Changes applied before test
commit eede0f7beea1ffd1ec55a49c5d05873067874bb0
Author: Thibault Allançon <haltode@gmail.com>
Date:   Fri Nov 27 17:50:55 2020 +0100

    tests: use fixed delay in test_list_history
    
    Closes T2829. The ".status" file presence is currently not a reliable
    system to stop the delay, so use a fixed one instead to prevent random
    CI fails.
    
    TODO: new task about re-doing the .status implementation

See https://jenkins.softwareheritage.org/job/DFUSE/job/tests-on-diff/201/ for more details.

Harbormaster completed remote builds in B17620: Diff 16431.Nov 30 2020, 4:22 PM
haltode updated this revision to Diff 16432.Nov 30 2020, 4:28 PM

another CI test.

swh-public-ci added a comment.Nov 30 2020, 4:31 PM

Build is green

Patch application report for D4628 (id=16432)

Rebasing onto 1c778776d8...

Current branch diff-target is up to date.
Changes applied before test
commit eede0f7beea1ffd1ec55a49c5d05873067874bb0
Author: Thibault Allançon <haltode@gmail.com>
Date:   Fri Nov 27 17:50:55 2020 +0100

    tests: use fixed delay in test_list_history
    
    Closes T2829. The ".status" file presence is currently not a reliable
    system to stop the delay, so use a fixed one instead to prevent random
    CI fails.
    
    TODO: new task about re-doing the .status implementation

See https://jenkins.softwareheritage.org/job/DFUSE/job/tests-on-diff/202/ for more details.

Harbormaster completed remote builds in B17621: Diff 16432.Nov 30 2020, 4:31 PM
haltode updated this revision to Diff 16433.Nov 30 2020, 4:45 PM

last CI test

swh-public-ci added a comment.Nov 30 2020, 4:48 PM

Build is green

Patch application report for D4628 (id=16433)

Rebasing onto 1c778776d8...

Current branch diff-target is up to date.
Changes applied before test
commit eede0f7beea1ffd1ec55a49c5d05873067874bb0
Author: Thibault Allançon <haltode@gmail.com>
Date:   Fri Nov 27 17:50:55 2020 +0100

    tests: use fixed delay in test_list_history
    
    Closes T2829. The ".status" file presence is currently not a reliable
    system to stop the delay, so use a fixed one instead to prevent random
    CI fails.
    
    TODO: new task about re-doing the .status implementation

See https://jenkins.softwareheritage.org/job/DFUSE/job/tests-on-diff/203/ for more details.

Harbormaster completed remote builds in B17622: Diff 16433.Nov 30 2020, 4:48 PM
haltode mentioned this in T2830: FUSE: history/by-date/.status file implementation does not seem reliable.Nov 30 2020, 4:58 PM
haltode updated this revision to Diff 16436.Nov 30 2020, 5:01 PM

Update commit message

swh-public-ci added a comment.Nov 30 2020, 5:04 PM

Build is green

Patch application report for D4628 (id=16436)

Rebasing onto 1c778776d8...

Current branch diff-target is up to date.
Changes applied before test
commit 91da32397917d80086467c7ea5100974511b1bcf
Author: Thibault Allançon <haltode@gmail.com>
Date:   Fri Nov 27 17:50:55 2020 +0100

    tests: use fixed delay in test_list_history
    
    Closes T2829. The ".status" file presence is currently not a reliable
    system to stop the delay, so use a fixed one instead to prevent random
    CI fails. The .status issue is now tracked in T2830.

See https://jenkins.softwareheritage.org/job/DFUSE/job/tests-on-diff/204/ for more details.

Harbormaster completed remote builds in B17624: Diff 16436.Nov 30 2020, 5:04 PM
zack accepted this revision.Nov 30 2020, 5:05 PM
Closed by commit rDFUSE91da32397917: tests: use fixed delay in test_list_history (authored by haltode). · Explain WhyNov 30 2020, 5:22 PM
This revision was automatically updated to reflect the committed changes.
haltode added a commit: rDFUSE91da32397917: tests: use fixed delay in test_list_history.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
swh/
fuse/
tests/
8 lines100%
Loading...

Diff 16436

View Options

swh/fuse/tests/test_revision.py

Loading...
About · Developer information · Legal