Differential D4621

Make the in-memory kafka writer call unique_key().
ClosedPublic
Actions

Authored by vlorentz on Nov 27 2020, 1:31 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDJNL12b31a2621e9: Make the in-memory kafka writer call unique_key().

Summary

So that errors in unique_key() are caught by tests using the in-mem writer.

Diff Detail

Repository

rDJNL Journal infrastructure

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Nov 27 2020, 1:31 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 27 2020, 1:31 PM

Build is green

Patch application report for D4621 (id=16385)

Rebasing onto 1a6c825884...

Current branch diff-target is up to date.

Changes applied before test

commit 12b31a2621e9cb9c606a4603c9968c33fb0c67d4
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Nov 27 13:30:47 2020 +0100

    Make the in-memory kafka writer call unique_key().
    
    So that errors in unique_key() are caught by tests using the in-mem writer.

See https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/127/ for more details.

Harbormaster completed remote builds in B17577: Diff 16385.Nov 27 2020, 1:33 PM

huh? Why is it not covered?

otherwise, fine i guess.

This revision is now accepted and ready to land.Nov 27 2020, 1:39 PM

Because I didn't write tests for this at all. But it's only used in tests, so 🤷

I'll open a task to write tests for it.

vlorentz mentioned this in T2823: Write tests for swh/journal/writer/inmemory.py.Nov 27 2020, 1:50 PM

Closed by commit rDJNL12b31a2621e9: Make the in-memory kafka writer call unique_key(). (authored by vlorentz). · Explain WhyNov 27 2020, 3:33 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDJNL12b31a2621e9: Make the in-memory kafka writer call unique_key()..