Page MenuHomeSoftware Heritage

Make the in-memory kafka writer call unique_key().
ClosedPublic

Authored by vlorentz on Nov 27 2020, 1:31 PM.

Details

Summary

So that errors in unique_key() are caught by tests using the in-mem writer.

Diff Detail

Repository
rDJNL Journal infrastructure
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D4621 (id=16385)

Rebasing onto 1a6c825884...

Current branch diff-target is up to date.
Changes applied before test
commit 12b31a2621e9cb9c606a4603c9968c33fb0c67d4
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Nov 27 13:30:47 2020 +0100

    Make the in-memory kafka writer call unique_key().
    
    So that errors in unique_key() are caught by tests using the in-mem writer.

See https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/127/ for more details.

otherwise, fine i guess.

This revision is now accepted and ready to land.Nov 27 2020, 1:39 PM

Because I didn't write tests for this at all. But it's only used in tests, so 🤷

I'll open a task to write tests for it.