The previous implementation would always append extra_encoders to the main
ENCODERS list. Refactor encoder and decoder extensions both with a common getter
which doesn't mutate the global variable.
Details
Details
- Reviewers
anlambert - Group Reviewers
Reviewers - Commits
- rDCORE2c9ea80cab85: Do not mutate swh.core.api.serializers.ENCODERS or DECODERS
Added a tox test to check for the mutation
Diff Detail
Diff Detail
- Repository
- rDCORE Foundations and core functionalities
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 17442 Build 26952: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 26951: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
Patch application report for D4572 (id=16250)
Rebasing onto f269e2d3d0...
Current branch diff-target is up to date.
Changes applied before test
commit 2c9ea80cab851dcacbd3047aad52afb14622bdac Author: Nicolas Dandrimont <nicolas@dandrimont.eu> Date: Tue Nov 24 12:50:47 2020 +0100 Do not mutate swh.core.api.serializers.ENCODERS or DECODERS The previous implementation would always append extra_encoders to the main ENCODERS list. Refactor encoder and decoder extensions both with a common getter which doesn't mutate the global variable.
See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/168/ for more details.