Page MenuHomeSoftware Heritage
Differential D4561

Drop no longer used db utilities
ClosedPublic
Actions

Authored by ardumont on Nov 23 2020, 6:02 PM.

Details

Reviewers
anlambert
Group Reviewers
Reviewers
Commits
rDCOREe0e55b71cce9: Drop no longer used db utilities
Summary

This utility tests were only used within swh.core.
By dropping those, we can then stop installing pifpaf within tox.

Test Plan

tox

Diff Detail

Repository
rDCORE Foundations and core functionalities
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Nov 23 2020, 6:02 PM
ardumont retitled this revision from Drop no longer remnant of db utilities which pulled pifpaf within tox to Drop db utilities remnants no longer used.Nov 23 2020, 6:03 PM
swh-public-ci added a comment.Nov 23 2020, 6:04 PM

Build is green

Patch application report for D4561 (id=16208)

Rebasing onto 7b38110bca...

First, rewinding head to replay your work on top of it...
Applying: Drop no longer remnant of db utilities which pulled pifpaf within tox
Changes applied before test
commit dcda0a67620283c0cf30d9ba5671ff259667d9aa
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Nov 23 17:59:45 2020 +0100

    Drop no longer remnant of db utilities which pulled pifpaf within tox
    
    This utility tests were only used within swh.core.
    By dropping those, we can then stop installing pifpaf within tox.

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/158/ for more details.

Harbormaster completed remote builds in B17407: Diff 16208.Nov 23 2020, 6:04 PM
ardumont updated this revision to Diff 16209.Nov 23 2020, 6:08 PM

Rework commit message

swh-public-ci added a comment.Nov 23 2020, 6:09 PM

Build is green

Patch application report for D4561 (id=16209)

Rebasing onto 7b38110bca...

First, rewinding head to replay your work on top of it...
Applying: Drop no longer db utilities
Changes applied before test
commit dc71ed97207c54d6eab509a5b889cfe95867a00e
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Nov 23 17:59:45 2020 +0100

    Drop no longer db utilities
    
    Those db utilities were only used within swh.core. By dropping those, we can
    then stop installing pifpaf within tox for the db tests.
    
    The tests are now probably faster than before as well.

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/159/ for more details.

Harbormaster completed remote builds in B17408: Diff 16209.Nov 23 2020, 6:09 PM
ardumont updated this revision to Diff 16211.Nov 23 2020, 6:18 PM

Simplify db init

ardumont updated this revision to Diff 16212.Nov 23 2020, 6:18 PM

Fix commit message

ardumont retitled this revision from Drop db utilities remnants no longer used to Drop no longer used db utilities.Nov 23 2020, 6:18 PM
swh-public-ci added a comment.Nov 23 2020, 6:19 PM

Build is green

Patch application report for D4561 (id=16211)

Rebasing onto 7b38110bca...

First, rewinding head to replay your work on top of it...
Applying: Drop no longer db utilities
Changes applied before test
commit dd9116b917d05f2b12c57fe1900c567cd49c73cb
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Nov 23 17:59:45 2020 +0100

    Drop no longer db utilities
    
    Those db utilities were only used within swh.core. By dropping those, we can
    then stop installing pifpaf within tox for the db tests.
    
    The tests are now probably faster than before as well.

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/160/ for more details.

Harbormaster completed remote builds in B17410: Diff 16211.Nov 23 2020, 6:19 PM
anlambert added inline comments.Nov 23 2020, 6:20 PM
tox.ini
14

You must drop the db: prefix on that line as the command must be applied to all tests suite

swh-public-ci added a comment.Nov 23 2020, 6:20 PM

Build is green

Patch application report for D4561 (id=16212)

Rebasing onto 7b38110bca...

First, rewinding head to replay your work on top of it...
Applying: Drop no longer used db utilities
Changes applied before test
commit d6f6f12b80b0375700de8b358c60b34e6299c0a3
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Nov 23 17:59:45 2020 +0100

    Drop no longer used db utilities
    
    Those db utilities were only used within swh.core. By dropping those, we can
    then stop installing pifpaf within tox for the db tests.
    
    The tests are now probably faster than before as well.

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/161/ for more details.

Harbormaster completed remote builds in B17411: Diff 16212.Nov 23 2020, 6:20 PM
ardumont added inline comments.Nov 23 2020, 6:20 PM
tox.ini
14

oh right, i misread that part, thanks!

ardumont updated this revision to Diff 16214.Nov 23 2020, 6:21 PM

Fix typo in tox.ini

ardumont marked an inline comment as done.Nov 23 2020, 6:22 PM
anlambert added inline comments.Nov 23 2020, 6:22 PM
swh/core/db/tests/test_db.py
257

you can drop that line as it is already executed in the fixture

swh-public-ci added a comment.Nov 23 2020, 6:22 PM

Build is green

Patch application report for D4561 (id=16214)

Rebasing onto 7b38110bca...

First, rewinding head to replay your work on top of it...
Applying: Drop no longer used db utilities
Changes applied before test
commit d7e661b8628b9447116cc40c5e310ca5610195e2
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Nov 23 17:59:45 2020 +0100

    Drop no longer used db utilities
    
    Those db utilities were only used within swh.core. By dropping those, we can
    then stop installing pifpaf within tox for the db tests.
    
    The tests are now probably faster than before as well.

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/162/ for more details.

Harbormaster completed remote builds in B17413: Diff 16214.Nov 23 2020, 6:22 PM
ardumont updated this revision to Diff 16215.Nov 23 2020, 6:34 PM

Update pytest.ini with filterwarning

swh-public-ci added a comment.Nov 23 2020, 6:35 PM

Build is green

Patch application report for D4561 (id=16215)

Rebasing onto 7b38110bca...

First, rewinding head to replay your work on top of it...
Applying: Drop no longer used db utilities
Changes applied before test
commit 558f0fa74d65d57b77def4d24412397fcdc36fe6
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Nov 23 17:59:45 2020 +0100

    Drop no longer used db utilities
    
    Those db utilities were only used within swh.core. By dropping those, we can
    then stop installing pifpaf within tox for the db tests.
    
    The tests are now probably faster than before as well.

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/163/ for more details.

Harbormaster completed remote builds in B17414: Diff 16215.Nov 23 2020, 6:35 PM
anlambert accepted this revision.Nov 23 2020, 6:37 PM

Looks good to me, bye bye pifpaf !

This revision is now accepted and ready to land.Nov 23 2020, 6:37 PM
ardumont updated this revision to Diff 16216.Nov 23 2020, 6:38 PM

Fix docstring typo

swh-public-ci added a comment.Nov 23 2020, 6:39 PM

Build is green

Patch application report for D4561 (id=16216)

Rebasing onto 7b38110bca...

First, rewinding head to replay your work on top of it...
Applying: Drop no longer used db utilities
Changes applied before test
commit 4c2895fab31826fda9b26e2964e54a65d7932fcd
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Nov 23 17:59:45 2020 +0100

    Drop no longer used db utilities
    
    Those db utilities were only used within swh.core. By dropping those, we can
    then stop installing pifpaf within tox for the db tests.
    
    The tests are now probably faster than before as well.

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/164/ for more details.

Harbormaster completed remote builds in B17415: Diff 16216.Nov 23 2020, 6:39 PM
ardumont mentioned this in D4543: setup: Separate pytest-postgresql dependency and declare it when needed.Nov 23 2020, 6:42 PM
ardumont updated this revision to Diff 16217.Nov 23 2020, 6:43 PM

Rebase

swh-public-ci added a comment.Nov 23 2020, 6:44 PM

Build is green

Patch application report for D4561 (id=16217)

Rebasing onto 7b38110bca...

Current branch diff-target is up to date.
Changes applied before test
commit e0e55b71cce9bb75204b7ab74a0c749215785d1f
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Nov 23 17:59:45 2020 +0100

    Drop no longer used db utilities
    
    Those db utilities were only used within swh.core. By dropping those, we can
    then stop installing pifpaf within tox for the db tests.
    
    The tests are now probably faster than before as well.

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/165/ for more details.

Harbormaster completed remote builds in B17416: Diff 16217.Nov 23 2020, 6:44 PM
Closed by commit rDCOREe0e55b71cce9: Drop no longer used db utilities (authored by ardumont). · Explain WhyNov 23 2020, 6:49 PM
This revision was automatically updated to reflect the committed changes.
ardumont added a commit: rDCOREe0e55b71cce9: Drop no longer used db utilities.

Revision Contents
Changeset List

PathSize
2 lines
swh/
core/
db/
tests/
109 lines
4 lines

Diff 16218

View Options

pytest.ini

Loading...
View Options

swh/core/db/tests/db_testing.py

Loading...
View Options

swh/core/db/tests/test_db.py

Loading...
View Options

tox.ini

Loading...
About · Developer information · Legal