Page MenuHomeSoftware Heritage

Make 'make' in swh-*/docs/ should run 'make' in swh-*/docs/images/
AbandonedPublic

Authored by vlorentz on Oct 1 2018, 5:26 PM.

Details

Reviewers
zack

Diff Detail

Repository
rDDOC Development documentation
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1470
Build 1814: arc lint + arc unit

Event Timeline

Thanks, this was indeed a problem and this solution works.

However, I don't like it's interface, which forces to handle the special case of the images/ dir at the global level. I'd rather have a local solution where needed, similarly to what we already have in, e.g., swh-loader-tar/docs/Makefile or swh-loader-dir/docs/Makefile.

The makefiles that needs to do something special should add the needed dependency. So I think you should abandon this diff and update D454 and D455 to do something similar the above Makefiles.

zack requested changes to this revision.Oct 1 2018, 7:34 PM
This revision now requires changes to proceed.Oct 1 2018, 7:34 PM
This comment was removed by vlorentz.
This comment was removed by vlorentz.
zack requested changes to this revision.Oct 2 2018, 4:53 PM

updating diff status to match the current state of the discussion

This revision now requires changes to proceed.Oct 2 2018, 4:53 PM

as discussed, this diff should be abandoned