Page MenuHomeSoftware Heritage

Add test_post_deposit_binary_upload_fail_if_content_length_missing.
ClosedPublic

Authored by vlorentz on Thu, Nov 19, 10:43 AM.

Diff Detail

Repository
rDDEP Push deposit
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Thu, Nov 19, 10:43 AM

Build is green

Patch application report for D4519 (id=16020)

Could not rebase; Attempt merge onto bacbc29731...

Updating bacbc297..60f443cd
Fast-forward
 swh/deposit/api/common.py                          | 60 +++++++++++++---------
 .../tests/api/test_collection_post_binary.py       | 37 +++++++++++++
 2 files changed, 73 insertions(+), 24 deletions(-)
Changes applied before test
commit 60f443cdd962575f2e4559a4ffcfa7f57cc7b466
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Nov 19 10:43:03 2020 +0100

    Add test_post_deposit_binary_upload_fail_if_content_length_missing.

commit 0e72920bb8bba285abd2f201aa934a626824b681
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Nov 19 10:37:34 2020 +0100

    Split _check_preconditions_on into _check_file_length and _check_file_md5sum.
    
    they are better function names IMO.

commit 43edd9039f23a5ff449897ba7ff4c59ac3868197
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Nov 18 16:31:09 2020 +0100

    Remove duplicate type annotations.
    
    They are already in the signature.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/383/ for more details.

ardumont accepted this revision.Thu, Nov 19, 12:00 PM
ardumont added a subscriber: ardumont.

right, thx

This revision is now accepted and ready to land.Thu, Nov 19, 12:00 PM