Differential D4499

deposit_* to be consistent with SWORD terminology.
ClosedPublic
Actions

Authored by vlorentz on Nov 18 2020, 11:10 AM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDDEP329a2a3785ad: Rename files and classes in swh/deposit/api/deposit_* to be consistent with…

Diff Detail

Repository

rDDEP Push deposit

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 17164
Build 26497: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 26496: arc lint + arc unit

Event Timeline

vlorentz created this revision.Nov 18 2020, 11:10 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 18 2020, 11:10 AM

Build is green

Patch application report for D4499 (id=15959)

Rebasing onto c1a45162d3...

Current branch diff-target is up to date.

Changes applied before test

commit 2cc3f33a7f284deb251c73740637acf290a4a902
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Nov 18 11:10:49 2020 +0100

    Rename files and classes in swh/deposit/api/deposit_* to be consistent with SWORD terminology.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/355/ for more details.

Harbormaster completed remote builds in B17164: Diff 15959.Nov 18 2020, 11:13 AM

Please update the test files as well.
(That also needs a rebase).

This revision now requires changes to proceed.Nov 18 2020, 11:30 AM

rebase + rename test files.

vlorentz added a child revision: D4500: remove assumption that Edit-IRI and SE-IRI are the same from test_post_deposit_atom_entry_multiple_steps..Nov 18 2020, 12:13 PM

Build has FAILED

Patch application report for D4499 (id=15964)

Rebasing onto a67ed6b06b...

Current branch diff-target is up to date.

Changes applied before test

commit d7f5a6f60ecff310675775c58be34a87d9b691a5
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Nov 18 11:10:49 2020 +0100

    Rename files and classes in swh/deposit/api/deposit_* to be consistent with SWORD terminology.

Link to build: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/356/
See console output for more information: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/356/console

Harbormaster failed remote builds in B17169: Diff 15964!Nov 18 2020, 12:15 PM

meh, I can't use a subdir for the tests

Build is green

Patch application report for D4499 (id=15969)

Rebasing onto a67ed6b06b...

Current branch diff-target is up to date.

Changes applied before test

commit 329a2a3785ad8431fa7ec73fee31e86dbee36911
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Nov 18 11:10:49 2020 +0100

    Rename files and classes in swh/deposit/api/deposit_* to be consistent with SWORD terminology.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/359/ for more details.

Harbormaster completed remote builds in B17174: Diff 15969.Nov 18 2020, 12:24 PM

I'll assume it's fine.

I'm completely dusty on the sword v2 terms now.

This revision is now accepted and ready to land.Nov 18 2020, 2:30 PM