Page MenuHomeSoftware Heritage

Rename files and classes in swh/deposit/api/deposit_* to be consistent with SWORD terminology.
ClosedPublic

Authored by vlorentz on Wed, Nov 18, 11:10 AM.

Diff Detail

Repository
rDDEP Push deposit
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Wed, Nov 18, 11:10 AM

Build is green

Patch application report for D4499 (id=15959)

Rebasing onto c1a45162d3...

Current branch diff-target is up to date.
Changes applied before test
commit 2cc3f33a7f284deb251c73740637acf290a4a902
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Nov 18 11:10:49 2020 +0100

    Rename files and classes in swh/deposit/api/deposit_* to be consistent with SWORD terminology.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/355/ for more details.

ardumont requested changes to this revision.EditedWed, Nov 18, 11:30 AM
ardumont added a subscriber: ardumont.

Please update the test files as well.
(That also needs a rebase).

This revision now requires changes to proceed.Wed, Nov 18, 11:30 AM
vlorentz updated this revision to Diff 15964.Wed, Nov 18, 12:12 PM

rebase + rename test files.

Build has FAILED

Patch application report for D4499 (id=15964)

Rebasing onto a67ed6b06b...

Current branch diff-target is up to date.
Changes applied before test
commit d7f5a6f60ecff310675775c58be34a87d9b691a5
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Nov 18 11:10:49 2020 +0100

    Rename files and classes in swh/deposit/api/deposit_* to be consistent with SWORD terminology.

Link to build: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/356/
See console output for more information: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/356/console

vlorentz updated this revision to Diff 15969.Wed, Nov 18, 12:19 PM

meh, I can't use a subdir for the tests

Build is green

Patch application report for D4499 (id=15969)

Rebasing onto a67ed6b06b...

Current branch diff-target is up to date.
Changes applied before test
commit 329a2a3785ad8431fa7ec73fee31e86dbee36911
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Nov 18 11:10:49 2020 +0100

    Rename files and classes in swh/deposit/api/deposit_* to be consistent with SWORD terminology.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/359/ for more details.

ardumont accepted this revision.Wed, Nov 18, 2:30 PM

I'll assume it's fine.

I'm completely dusty on the sword v2 terms now.

This revision is now accepted and ready to land.Wed, Nov 18, 2:30 PM

I'll assume it's fine.

I'm completely dusty on the sword v2 terms now.

just check names match the docstrings you wrote ;)

I'll assume it's fine.

I'm completely dusty on the sword v2 terms now.

just check names match the docstrings you wrote ;)

yes, that's what i did ;)