Page MenuHomeSoftware Heritage

Drop backwards-compatibility support for RawExtrinsicMetadata.id
ClosedPublic

Authored by olasd on Nov 16 2020, 7:32 PM.

Details

Summary

All reverse dependencies have been updated to avoid using it now, so it can now
be removed, paving the way to recycle it into an intrinsic identifier.

Test Plan

pytest run in most other modules seems happy

Diff Detail

Repository
rDMOD Data model
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17121
Build 26424: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 26423: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D4487 (id=15916)

Rebasing onto 8e121bbc0d...

Current branch diff-target is up to date.
Changes applied before test
commit a3b6a6448011c77202909549c59e39a49acf0cb4
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Mon Nov 16 18:51:31 2020 +0100

    Drop backwards-compatibility support for RawExtrinsicMetadata.id
    
    All reverse dependencies have been updated to avoid using it now, so it can now
    be removed, paving the way to recycle it into an intrinsic identifier.

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/184/ for more details.

This revision is now accepted and ready to land.Nov 17 2020, 12:27 AM