Differential D4487

Drop backwards-compatibility support for RawExtrinsicMetadata.id
ClosedPublic
Actions

Authored by olasd on Nov 16 2020, 7:32 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDMODa3b6a6448011: Drop backwards-compatibility support for RawExtrinsicMetadata.id

Summary

All reverse dependencies have been updated to avoid using it now, so it can now
be removed, paving the way to recycle it into an intrinsic identifier.

Test Plan

pytest run in most other modules seems happy

Diff Detail

Repository

rDMOD Data model

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Nov 16 2020, 7:32 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 16 2020, 7:32 PM

Build is green

Patch application report for D4487 (id=15916)

Rebasing onto 8e121bbc0d...

Current branch diff-target is up to date.

Changes applied before test

commit a3b6a6448011c77202909549c59e39a49acf0cb4
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Mon Nov 16 18:51:31 2020 +0100

    Drop backwards-compatibility support for RawExtrinsicMetadata.id
    
    All reverse dependencies have been updated to avoid using it now, so it can now
    be removed, paving the way to recycle it into an intrinsic identifier.

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/184/ for more details.

Harbormaster completed remote builds in B17121: Diff 15916.Nov 16 2020, 7:33 PM

vlorentz accepted this revision.Nov 17 2020, 12:27 AM

This revision is now accepted and ready to land.Nov 17 2020, 12:27 AM

Closed by commit rDMODa3b6a6448011: Drop backwards-compatibility support for RawExtrinsicMetadata.id (authored by olasd). · Explain WhyNov 17 2020, 10:12 AM

This revision was automatically updated to reflect the committed changes.

olasd added a commit: rDMODa3b6a6448011: Drop backwards-compatibility support for RawExtrinsicMetadata.id.