Page MenuHomeSoftware Heritage
Differential D4468

Remove test_post_deposit_atom_entry_tei.
ClosedPublic
Actions

Authored by vlorentz on Nov 12 2020, 6:34 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDDEPf15e63918ea4: Remove test_post_deposit_atom_entry_tei.
Summary

We barely support it, and no one uses it.

Additionally, a future commit will outright refuse documents without
an atom:author or atom:title.

Diff Detail

Unit TestsFailed
View All

TimeTest
526 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.deposit.tests.api.test_collection_post_atom::test_post_deposit_atom_with_external_identifier
authenticated_client = <rest_framework.test.APIClient object at 0x7fd88391d7b8> deposit_collection = <DepositCollection: {'id': 13, 'name': 'test'}> atom_dataset = {'codemeta-sample': '<?xml version="1.0"?>\n <entry xmlns="http://www.w3.org/2005/Atom"\n xmlns:d...ntry>\n', 'entry-data-empty-body': '<?xml version="1.0"?>\n<entry xmlns="http://www.w3.org/2005/Atom"></entry>\n', ...}
411 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.deposit.tests.api.test_checks::test_api_checks_check_metadata_ko[metadata_ko0-expected_summary0]
404 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.deposit.tests.api.test_checks::test_api_checks_check_metadata_ko[metadata_ko1-expected_summary1]
405 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.deposit.tests.api.test_checks::test_api_checks_check_metadata_ok[metadata_ok0]
206 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.deposit.tests.api.test_checks::test_api_checks_check_metadata_ok[metadata_ok1]
View Full Test Results (1 Failed · 210 Passed)

Event Timeline

vlorentz created this revision.Nov 12 2020, 6:34 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptNov 12 2020, 6:34 PM
swh-public-ci added a comment.Nov 12 2020, 6:37 PM

Build is green

Patch application report for D4468 (id=15860)

Could not rebase; Attempt merge onto 4d7d80c1b8...

Removing swh/deposit/tests/data/atom/tei-sample.xml
Merge made by the 'recursive' strategy.
 docs/endpoints/content.rst                         |  2 -
 docs/metadata.rst                                  |  9 ---
 docs/specs/metadata_example.xml                    |  1 -
 docs/specs/spec-loading.rst                        |  3 +-
 docs/specs/spec-meta-deposit.rst                   |  2 -
 docs/specs/spec-sparse-deposit.rst                 |  2 -
 docs/user-manual.rst                               |  2 -
 swh/deposit/api/common.py                          | 16 ++++-
 swh/deposit/tests/api/test_deposit.py              |  6 +-
 swh/deposit/tests/api/test_deposit_atom.py         | 73 ++++++++--------------
 swh/deposit/tests/api/test_deposit_update.py       | 12 ++--
 swh/deposit/tests/conftest.py                      |  2 +-
 swh/deposit/tests/data/atom/codemeta-sample.xml    |  1 -
 .../entry-data-fail-metadata-functional-checks.xml |  1 -
 swh/deposit/tests/data/atom/entry-data-minimal.xml |  2 +-
 swh/deposit/tests/data/atom/entry-data0.xml        |  2 -
 swh/deposit/tests/data/atom/entry-data1.xml        |  1 -
 swh/deposit/tests/data/atom/entry-data2.xml        |  1 -
 swh/deposit/tests/data/atom/error-with-decimal.xml |  2 -
 .../data/atom/error-with-external-identifier.xml   |  6 ++
 swh/deposit/tests/data/atom/metadata.xml           |  2 -
 swh/deposit/tests/data/atom/tei-sample.xml         |  1 -
 22 files changed, 56 insertions(+), 93 deletions(-)
 create mode 100644 swh/deposit/tests/data/atom/error-with-external-identifier.xml
 delete mode 100644 swh/deposit/tests/data/atom/tei-sample.xml
Changes applied before test
commit a7c0e53e98e65b8d4c55cdd4347d808fee88affa
Merge: 4d7d80c1 21b667dc
Author: Jenkins user <jenkins@localhost>
Date:   Thu Nov 12 17:34:39 2020 +0000

    Merge branch 'diff-target' into HEAD

commit 21b667dc79142e2bd7560ead2324543406531800
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Nov 12 18:34:08 2020 +0100

    Remove test_post_deposit_atom_entry_tei.
    
    We barely support it, and no one uses it.
    
    Additionally, a future commit will outright refuse documents without
    an atom:author or atom:title.

commit a85b22ca7e5f3e2e47c3b06b4ea323bb830f1565
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Nov 12 15:01:38 2020 +0100

    Remove the <client> tag from the protocol.
    
    It didn't match the Atom specification, and isn't used anywhere.

commit 4793f2ef85561d473a0b9932367b40d4a449ae7f
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Nov 12 14:47:09 2020 +0100

    Remove the <external_identifier> tag from the protocol.
    
    It didn't match the Atom specification, duplicates the Slug header,
    while being optional and specified as 'SHOULD match the Slug'.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/326/ for more details.

Harbormaster completed remote builds in B17069: Diff 15860.Nov 12 2020, 6:37 PM
ardumont accepted this revision.Nov 13 2020, 9:35 AM
ardumont added a subscriber: ardumont.

lgtm

That test was added as a tryout i think and at the time I did not
yet explained the reasons on the commit message... [1]
So now, I don't remember exactly ¯\_(ツ)_/¯

Still, I recall:

  • we were not set yet on codemeta
  • we were experiencing multiple xml inputs
  • that test just ensured we supported parsing it without further modification on the server side.

[1] rDDEP4b9fec58eebe383581819b076925bfea872d90a0

This revision is now accepted and ready to land.Nov 13 2020, 9:35 AM
vlorentz updated this revision to Diff 16170.Nov 23 2020, 12:09 PM

rebase

vlorentz updated this revision to Diff 16173.Nov 23 2020, 12:14 PM

rebase

swh-public-ci added a comment.Nov 23 2020, 12:18 PM

Build has FAILED

Patch application report for D4468 (id=16170)

Could not rebase; Attempt merge onto a8e86a92ee...

Updating a8e86a92..a3ca125e
Fast-forward
 docs/metadata.rst                                  |  9 ---
 docs/specs/metadata_example.xml                    |  1 -
 docs/specs/spec-loading.rst                        |  3 +-
 docs/specs/spec-meta-deposit.rst                   |  2 -
 docs/specs/spec-sparse-deposit.rst                 |  2 -
 docs/user-manual.rst                               |  2 -
 swh/deposit/api/common.py                          | 15 ++---
 swh/deposit/tests/api/test_collection.py           |  6 +-
 swh/deposit/tests/api/test_collection_post_atom.py | 73 ++++++++--------------
 swh/deposit/tests/api/test_deposit_update.py       | 12 ++--
 swh/deposit/tests/conftest.py                      |  2 +-
 swh/deposit/tests/data/atom/codemeta-sample.xml    |  1 -
 .../entry-data-fail-metadata-functional-checks.xml |  1 -
 swh/deposit/tests/data/atom/entry-data-minimal.xml |  2 +-
 swh/deposit/tests/data/atom/entry-data0.xml        |  2 -
 swh/deposit/tests/data/atom/entry-data1.xml        |  1 -
 swh/deposit/tests/data/atom/entry-data2.xml        |  1 -
 swh/deposit/tests/data/atom/error-with-decimal.xml |  2 -
 .../data/atom/error-with-external-identifier.xml   |  6 ++
 swh/deposit/tests/data/atom/metadata.xml           |  2 -
 swh/deposit/tests/data/atom/tei-sample.xml         |  1 -
 21 files changed, 47 insertions(+), 99 deletions(-)
 create mode 100644 swh/deposit/tests/data/atom/error-with-external-identifier.xml
 delete mode 100644 swh/deposit/tests/data/atom/tei-sample.xml
Changes applied before test
commit a3ca125e76f82219e84946d1faaa7264b98fe796
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Nov 12 18:34:08 2020 +0100

    Remove test_post_deposit_atom_entry_tei.
    
    We barely support it, and no one uses it.
    
    Additionally, a future commit will outright refuse documents without
    an atom:author or atom:title.

commit 164a44c900efeb1875e155f367123e93befc8aac
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Nov 12 15:01:38 2020 +0100

    Remove the <client> tag from the protocol.
    
    It didn't match the Atom specification, and isn't used anywhere.

commit c5f89f7eb1e6e47d11f550a64e1d184036bb0ff6
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Nov 12 14:47:09 2020 +0100

    Remove the <external_identifier> tag from the protocol.
    
    It didn't match the Atom specification, duplicates the Slug header,
    while being optional and specified as 'SHOULD match the Slug'.

Link to build: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/418/
See console output for more information: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/418/console

Harbormaster failed remote builds in B17370: Diff 16170!Nov 23 2020, 12:18 PM
vlorentz updated this revision to Diff 16177.Nov 23 2020, 12:19 PM

rebase

swh-public-ci added a comment.Nov 23 2020, 12:27 PM

Build is green

Patch application report for D4468 (id=16173)

Could not rebase; Attempt merge onto a8e86a92ee...

Updating a8e86a92..0e3efafb
Fast-forward
 docs/metadata.rst                                  |  9 ---
 docs/specs/metadata_example.xml                    |  1 -
 docs/specs/spec-loading.rst                        |  3 +-
 docs/specs/spec-meta-deposit.rst                   |  2 -
 docs/specs/spec-sparse-deposit.rst                 |  2 -
 docs/user-manual.rst                               |  2 -
 swh/deposit/api/common.py                          | 27 ++++----
 swh/deposit/tests/api/test_collection.py           |  6 +-
 swh/deposit/tests/api/test_collection_post_atom.py | 73 ++++++++--------------
 swh/deposit/tests/api/test_deposit_update.py       | 12 ++--
 swh/deposit/tests/conftest.py                      |  2 +-
 swh/deposit/tests/data/atom/codemeta-sample.xml    |  1 -
 .../entry-data-fail-metadata-functional-checks.xml |  1 -
 swh/deposit/tests/data/atom/entry-data-minimal.xml |  2 +-
 swh/deposit/tests/data/atom/entry-data0.xml        |  2 -
 swh/deposit/tests/data/atom/entry-data1.xml        |  1 -
 swh/deposit/tests/data/atom/entry-data2.xml        |  1 -
 swh/deposit/tests/data/atom/error-with-decimal.xml |  2 -
 .../data/atom/error-with-external-identifier.xml   |  6 ++
 swh/deposit/tests/data/atom/metadata.xml           |  2 -
 swh/deposit/tests/data/atom/tei-sample.xml         |  1 -
 21 files changed, 59 insertions(+), 99 deletions(-)
 create mode 100644 swh/deposit/tests/data/atom/error-with-external-identifier.xml
 delete mode 100644 swh/deposit/tests/data/atom/tei-sample.xml
Changes applied before test
commit 0e3efafb96b2ca3e8b139a3e3d346f66e6bdca81
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Nov 12 18:34:08 2020 +0100

    Remove test_post_deposit_atom_entry_tei.
    
    We barely support it, and no one uses it.
    
    Additionally, a future commit will outright refuse documents without
    an atom:author or atom:title.

commit 0e3f4cf167801e38eaed0c2d9a1e213c9f440c55
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Nov 12 15:01:38 2020 +0100

    Remove the <client> tag from the protocol.
    
    It didn't match the Atom specification, and isn't used anywhere.

commit 4f51deebc413fcaac23730d4f3521ed2293f7f08
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Nov 12 14:47:09 2020 +0100

    Remove the <external_identifier> tag from the protocol.
    
    It didn't match the Atom specification, duplicates the Slug header,
    while being optional and specified as 'SHOULD match the Slug'.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/421/ for more details.

Harbormaster completed remote builds in B17373: Diff 16173.Nov 23 2020, 12:27 PM
swh-public-ci added a comment.Nov 23 2020, 12:36 PM

Build is green

Patch application report for D4468 (id=16177)

Could not rebase; Attempt merge onto a8e86a92ee...

Updating a8e86a92..e3749576
Fast-forward
 docs/metadata.rst                                  |  9 ---
 docs/specs/metadata_example.xml                    |  1 -
 docs/specs/spec-loading.rst                        |  3 +-
 docs/specs/spec-meta-deposit.rst                   |  2 -
 docs/specs/spec-sparse-deposit.rst                 |  2 -
 docs/user-manual.rst                               |  2 -
 swh/deposit/api/common.py                          | 25 +++++---
 swh/deposit/tests/api/test_collection.py           |  6 +-
 swh/deposit/tests/api/test_collection_post_atom.py | 73 ++++++++--------------
 swh/deposit/tests/api/test_deposit_update.py       | 12 ++--
 swh/deposit/tests/conftest.py                      |  2 +-
 swh/deposit/tests/data/atom/codemeta-sample.xml    |  1 -
 .../entry-data-fail-metadata-functional-checks.xml |  1 -
 swh/deposit/tests/data/atom/entry-data-minimal.xml |  2 +-
 swh/deposit/tests/data/atom/entry-data0.xml        |  2 -
 swh/deposit/tests/data/atom/entry-data1.xml        |  1 -
 swh/deposit/tests/data/atom/entry-data2.xml        |  1 -
 swh/deposit/tests/data/atom/error-with-decimal.xml |  2 -
 .../data/atom/error-with-external-identifier.xml   |  6 ++
 swh/deposit/tests/data/atom/metadata.xml           |  2 -
 swh/deposit/tests/data/atom/tei-sample.xml         |  1 -
 21 files changed, 58 insertions(+), 98 deletions(-)
 create mode 100644 swh/deposit/tests/data/atom/error-with-external-identifier.xml
 delete mode 100644 swh/deposit/tests/data/atom/tei-sample.xml
Changes applied before test
commit e374957629ce4beb19b6c6e5322087705586e614
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Nov 12 18:34:08 2020 +0100

    Remove test_post_deposit_atom_entry_tei.
    
    We barely support it, and no one uses it.
    
    Additionally, a future commit will outright refuse documents without
    an atom:author or atom:title.

commit cbc3d11561aeafb76340ceb64e85f0d91241858c
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Nov 12 15:01:38 2020 +0100

    Remove the <client> tag from the protocol.
    
    It didn't match the Atom specification, and isn't used anywhere.

commit dcf3c6e390e00e34da5ac03469da9cf7733d758c
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Nov 12 14:47:09 2020 +0100

    Remove the <external_identifier> tag from the protocol.
    
    It didn't match the Atom specification, duplicates the Slug header,
    while being optional and specified as 'SHOULD match the Slug'.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/424/ for more details.

Harbormaster completed remote builds in B17377: Diff 16177.Nov 23 2020, 12:36 PM
vlorentz updated this revision to Diff 16182.Nov 23 2020, 1:04 PM

rebase

swh-public-ci added a comment.Nov 23 2020, 1:13 PM

Build is green

Patch application report for D4468 (id=16182)

Could not rebase; Attempt merge onto a8e86a92ee...

Updating a8e86a92..f15e6391
Fast-forward
 docs/metadata.rst                                  |  9 ---
 docs/specs/metadata_example.xml                    |  1 -
 docs/specs/spec-loading.rst                        |  3 +-
 docs/specs/spec-meta-deposit.rst                   |  2 -
 docs/specs/spec-sparse-deposit.rst                 |  2 -
 docs/user-manual.rst                               |  2 -
 swh/deposit/api/common.py                          | 24 ++++---
 swh/deposit/tests/api/test_collection.py           |  6 +-
 swh/deposit/tests/api/test_collection_post_atom.py | 73 ++++++++--------------
 swh/deposit/tests/api/test_deposit_update.py       | 12 ++--
 swh/deposit/tests/conftest.py                      |  2 +-
 swh/deposit/tests/data/atom/codemeta-sample.xml    |  1 -
 .../entry-data-fail-metadata-functional-checks.xml |  1 -
 swh/deposit/tests/data/atom/entry-data-minimal.xml |  2 +-
 swh/deposit/tests/data/atom/entry-data0.xml        |  2 -
 swh/deposit/tests/data/atom/entry-data1.xml        |  1 -
 swh/deposit/tests/data/atom/entry-data2.xml        |  1 -
 swh/deposit/tests/data/atom/error-with-decimal.xml |  2 -
 .../data/atom/error-with-external-identifier.xml   |  6 ++
 swh/deposit/tests/data/atom/metadata.xml           |  2 -
 swh/deposit/tests/data/atom/tei-sample.xml         |  1 -
 21 files changed, 58 insertions(+), 97 deletions(-)
 create mode 100644 swh/deposit/tests/data/atom/error-with-external-identifier.xml
 delete mode 100644 swh/deposit/tests/data/atom/tei-sample.xml
Changes applied before test
commit f15e63918ea48d06f05110db853c8d3c24e0209f
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Nov 12 18:34:08 2020 +0100

    Remove test_post_deposit_atom_entry_tei.
    
    We barely support it, and no one uses it.
    
    Additionally, a future commit will outright refuse documents without
    an atom:author or atom:title.

commit 5826e1b60d169b41ae984669183f7c8262d6c260
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Nov 12 15:01:38 2020 +0100

    Remove the <client> tag from the protocol.
    
    It didn't match the Atom specification, and isn't used anywhere.

commit 78befb03cfd9c7b423b7e23b6ecd5580d0699941
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Nov 12 14:47:09 2020 +0100

    Remove the <external_identifier> tag from the protocol.
    
    It didn't match the Atom specification, duplicates the Slug header,
    while being optional and specified as 'SHOULD match the Slug'.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/427/ for more details.

Harbormaster completed remote builds in B17382: Diff 16182.Nov 23 2020, 1:13 PM
Closed by commit rDDEPf15e63918ea4: Remove test_post_deposit_atom_entry_tei. (authored by vlorentz). · Explain WhyNov 23 2020, 1:25 PM
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDDEPf15e63918ea4: Remove test_post_deposit_atom_entry_tei..

Revision Contents
Changeset List

PathSize
swh/
deposit/
tests/
api/
40 lines
data/
atom/

Diff 16170

View Options

swh/deposit/tests/api/test_collection_post_atom.py

Loading...
View Options

swh/deposit/tests/data/atom/tei-sample.xml

Loading...
About · Developer information · Legal