Page MenuHomeSoftware Heritage

loader.git.from_disk: Fix cli
AbandonedPublic

Authored by ardumont on Thu, Nov 12, 5:33 PM.

Details

Reviewers
None
Group Reviewers
Reviewers
Maniphest Tasks
T2770: Fix all icinga checks on staging webapp
Summary

I'll add some tests on this if it's possible (given that the cli is declared only through the main block, i'm not sure it is testable in that test)

Related to T2770#52497

Test Plan

tox

Diff Detail

Repository
rDLDG Git loader
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17068
Build 26342: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 26341: arc lint + arc unit

Event Timeline

ardumont created this revision.Thu, Nov 12, 5:33 PM

Build is green

Patch application report for D4467 (id=15859)

Rebasing onto 9eb1c08f1c...

Current branch diff-target is up to date.
Changes applied before test
commit 904dc8e7f301090b4017848e800c33b3e9c40c23
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Nov 12 17:32:30 2020 +0100

    loader.git.from_disk: Fix cli
    
    Related to T2770#52497

See https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/68/ for more details.

ardumont added inline comments.Thu, Nov 12, 5:35 PM
swh/loader/git/from_disk.py
410

i think that's redundant with what the loader does within already.

ardumont edited the summary of this revision. (Show Details)Thu, Nov 12, 5:37 PM
ardumont abandoned this revision.Fri, Nov 13, 10:21 AM

In favor of D4470