Differential D4467

loader.git.from_disk: Fix cli
AbandonedPublic
Actions

Authored by ardumont on Nov 12 2020, 5:33 PM.

Details

Reviewers

None

Group Reviewers

Reviewers

Maniphest Tasks

T2770: Fix all icinga checks on staging webapp

Summary

I'll add some tests on this if it's possible (given that the cli is declared only through the main block, i'm not sure it is testable in that test)

Related to T2770#52497

Test Plan

tox

Diff Detail

Repository

rDLDG Git loader

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 17068
Build 26342: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 26341: arc lint + arc unit

Event Timeline

ardumont created this revision.Nov 12 2020, 5:33 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 12 2020, 5:33 PM

Build is green

Patch application report for D4467 (id=15859)

Rebasing onto 9eb1c08f1c...

Current branch diff-target is up to date.

Changes applied before test

commit 904dc8e7f301090b4017848e800c33b3e9c40c23
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Nov 12 17:32:30 2020 +0100

    loader.git.from_disk: Fix cli
    
    Related to T2770#52497

See https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/68/ for more details.

Harbormaster completed remote builds in B17068: Diff 15859.Nov 12 2020, 5:35 PM

ardumont added inline comments.Nov 12 2020, 5:35 PM

swh/loader/git/from_disk.py
410	i think that's redundant with what the loader does within already.

ardumont edited the summary of this revision. (Show Details)Nov 12 2020, 5:37 PM

ardumont mentioned this in D4470: loader.git.from_disk: Register loader in `swh loader run` cli.Nov 13 2020, 10:04 AM

In favor of D4470

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

swh/

loader/

git/

from_disk.py

5 lines

77%

Diff 15859

View Options

swh/loader/git/from_disk.py

loader.git.from_disk: Fix cliAbandonedPublicActions